Fork choice filter changes #13464
Merged
Fork choice filter changes #13464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
|
Discussing offline the changes |
adiasg
force-pushed
the
filter-changes
branch
from
09353bf to
d14cc56
Compare
proto/ssz_proto_library.bzl
Outdated
| "max_blobs_per_block.size": "6", | ||
| "max_blob_commitments.size": "16", | ||
| "kzg_commitment_inclusion_proof_depth.size": "9", | ||
| "kzg_commitment_inclusion_proof_depth.size": "17", |
Member
There was a problem hiding this comment.
Please explain this change. Was there an upstream spec change for this?
Collaborator
There was a problem hiding this comment.
I believe it's this one: ethereum/consensus-specs#3255
Member
There was a problem hiding this comment.
This change fails test //testing/spectest/minimal/deneb/ssz_static:go_default_test
Contributor
There was a problem hiding this comment.
the blob size will not change the proof size, the proof is for the KZG commitment, the block is smaller so it needs a smaller Merkle Tree, I'm pushing a revert of this and approving this PR
adiasg
force-pushed
the
filter-changes
branch
2 times, most recently
from
18f3c60 to
600316b
Compare
Contributor
|
Blocking just in case cause I still don't understand a failing testcase |
potuz
previously approved these changes
Feb 9, 2024
potuz
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Changes the fork choice filteration logic as needed by ethereum/consensus-specs#3431