Deneb spectests release v1.4.0-beta.2-hotfix #12959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potuz
force-pushed
the
deneb-spectests
branch
7 times, most recently
from
7cd8a9b to
0910067
Compare
4 tasks
Collaborator
|
This PR also consisted the following changes which was previously approved on #12908 |
Comment on lines
+145
to
+151
| if state.Version() >= version.Deneb { | ||
| // Cap churn limit to max per epoch churn limit. New in EIP7514. | ||
| if churnLimit > params.BeaconConfig().MaxPerEpochActivationChurnLimit { | ||
| churnLimit = params.BeaconConfig().MaxPerEpochActivationChurnLimit | ||
| } | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Can we add unit tests for this? It's likely covered by spectest but we should have our own tests as well as spectests are a bit of a blackbox sometimes.
Member
|
Fails to build |
prestonvanloon
approved these changes
Sep 28, 2023
expose ReceiveBlob from the blockchain package
Co-authored-by: terencechain <terence@prysmaticlabs.com>
terencechain
force-pushed
the
deneb-spectests
branch
from
8b18b66 to
2b13797
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement deneb DA forkchoice spectests.
exports ReceiveBlob from the blockchain package