-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Align to consensus release v1.4.0-beta.2 #12908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
775d26a
d1240f7
435c043
f9a3388
9a0df0e
9313f6b
21f3dba
a0b7c25
82f1d5d
2424507
a87113d
6709652
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -96,6 +96,9 @@ func E2EMainnetTestConfig() *BeaconChainConfig { | |
| e2eConfig.CapellaForkVersion = []byte{3, 0, 0, 254} | ||
| e2eConfig.DenebForkVersion = []byte{4, 0, 0, 254} | ||
|
|
||
| // Deneb changes. | ||
| e2eConfig.MinPerEpochChurnLimit = 2 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do we not need max here?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It should just use the default which is 8 |
||
|
|
||
| e2eConfig.InitializeForkSchedule() | ||
| return e2eConfig | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,8 +29,6 @@ import ( | |
| "google.golang.org/protobuf/types/known/emptypb" | ||
| ) | ||
|
|
||
| // churnLimit is normally 4 unless the validator set is extremely large. | ||
| var churnLimit = 4 | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am removing this to use the default config |
||
| var depositValCount = e2e.DepositCount | ||
| var numOfExits = 2 | ||
|
|
||
|
|
@@ -39,7 +37,7 @@ var depositsInBlockStart = params.E2ETestConfig().EpochsPerEth1VotingPeriod * 2 | |
|
|
||
| // deposits included + finalization + MaxSeedLookahead for activation. | ||
| var depositActivationStartEpoch = depositsInBlockStart + 2 + params.E2ETestConfig().MaxSeedLookahead | ||
| var depositEndEpoch = depositActivationStartEpoch + primitives.Epoch(math.Ceil(float64(depositValCount)/float64(churnLimit))) | ||
| var depositEndEpoch = depositActivationStartEpoch + primitives.Epoch(math.Ceil(float64(depositValCount)/float64(params.BeaconConfig().MinPerEpochChurnLimit))) | ||
| var exitSubmissionEpoch = primitives.Epoch(7) | ||
|
|
||
| // ProcessesDepositsInBlocks ensures the expected amount of deposits are accepted into blocks. | ||
|
|
@@ -249,8 +247,8 @@ func activatesDepositedValidators(ec *e2etypes.EvaluationContext, conns ...*grpc | |
| return fmt.Errorf("missing %d validators for post-genesis deposits", len(expected)) | ||
| } | ||
|
|
||
| if deposits != churnLimit { | ||
| return fmt.Errorf("expected %d deposits to be processed in epoch %d, received %d", churnLimit, epoch, deposits) | ||
| if uint64(deposits) != params.BeaconConfig().MinPerEpochChurnLimit { | ||
| return fmt.Errorf("expected %d deposits to be processed in epoch %d, received %d", params.BeaconConfig().MinPerEpochChurnLimit, epoch, deposits) | ||
| } | ||
|
|
||
| if lowBalance > 0 { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we not need the min here too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's no change here