chore: improve att error#12813
Merged
terencechain merged 2 commits intodeneb-integrationfrom Aug 26, 2023
Merged
Conversation
terencechain
requested review from
potuz,
rkapka and
saolyn
and removed request for
a team
nisdas
reviewed
Aug 25, 2023
| currentEpoch, | ||
| prevEpoch, | ||
| ) | ||
| return errors.Join(ErrIncorrectEpoch, attError) |
Contributor
There was a problem hiding this comment.
We should add the same ErrTooLate here, as we check for this in gossip. If a message has this particular error, we skip logging it.
nisdas
approved these changes
Aug 25, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 30, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 30, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 31, 2023
james-prysm
pushed a commit
that referenced
this pull request
Aug 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
address a feedback from #12773