WIP: Deneb protos separated from deneb-integration#12770
Closed
WIP: Deneb protos separated from deneb-integration#12770
Conversation
kasey
changed the title
kasey
changed the title
This was referenced Aug 22, 2023
nisdas
reviewed
Aug 22, 2023
| // MarshalJSON -- | ||
| func (p *PayloadAttributesV2) MarshalJSON() ([]byte, error) { | ||
| withdrawals := p.Withdrawals | ||
| if withdrawals == nil { |
Collaborator
Author
There was a problem hiding this comment.
presumably this fixes an issue where an empty withdrawals list results in a nil slice. You're probably wondering why this isn't needed in capella/develop though, cc @terencechain who is on the blame.
Collaborator
There was a problem hiding this comment.
@kasey let's revert this. It's irreverent. Same for V3 as well. Nice catch guys
| "SignedBlindedBeaconBlockCapella", | ||
| "SignedBeaconBlockDeneb", | ||
| "SignedBlindedBeaconBlockDeneb", | ||
| "BlsToExecutionChange", |
Contributor
There was a problem hiding this comment.
Why are we add this in deneb ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
This PR separates
deneb-integrationprotobuf changes to reduce the line count in the diff to develop.Other notes for review
DO NOT MERGE
The plan for this branch is to provide a reference point for a more reviewable deneb-integration diff - a 3rd branch
deneb-integration-remainingis on the way, which will be set up in a PR against this branch (deneb-integration-proto). We can use that PR to get a cleaner diff (no proto changes). Ifdeneb-integration-remainingdiffs cleanly againstdeneb-integration, we can confidently fast-forward merge deneb-integration knowing that it has had this extra round of final review.This will break attribution/history and likely cause a messy rebase. This is a second attempt after trying to also integrate consensus-types and gateway changes, which spiraled out into other areas of the code.
Files from the
protopackage that were left behind to avoid breaking changes when the rest of the branch is missing: