Deneb: publishblockv2 endpoint#12662
Merged
james-prysm merged 1 commit intodeneb-integrationfrom Jul 26, 2023
Merged
Conversation
james-prysm
requested review from
potuz,
prestonvanloon and
saolyn
and removed request for
a team
james-prysm
commented
Jul 25, 2023
| require.NoError(t, err) | ||
| genericBlock, err := dblock.ToGeneric() | ||
| require.NoError(t, err) | ||
| v2block, err := migration.V1Alpha1SignedBeaconBlockDenebAndBlobsToV2(genericBlock.GetDeneb()) |
Contributor
Author
There was a problem hiding this comment.
I wonder if we should just have blockandblobs ssz marshalable instead...
james-prysm
force-pushed
the
deneb-publish-blockv2
branch
from
d152926 to
227d1d2
Compare
terencechain
approved these changes
Jul 25, 2023
rkapka
previously requested changes
Jul 26, 2023
james-prysm
added a commit
that referenced
this pull request
Aug 4, 2023
terencechain
pushed a commit
that referenced
this pull request
Aug 4, 2023
james-prysm
added a commit
that referenced
this pull request
Aug 8, 2023
james-prysm
added a commit
that referenced
this pull request
Aug 9, 2023
james-prysm
added a commit
that referenced
this pull request
Aug 14, 2023
terencechain
pushed a commit
that referenced
this pull request
Aug 16, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 21, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 22, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 22, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 22, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 23, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 23, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 23, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 24, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
fixing broken test (#12673)
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
fixing broken test (#12673)
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 30, 2023
fixing broken test (#12673)
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 30, 2023
fixing broken test (#12673)
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 31, 2023
fixing broken test (#12673)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Implements the following, unit test values should be updated with sample data instead of using mock data.
Implements the following APIs for Deneb
publishBlindedBlockV2jsonpublishBlindedBlockV2sszpublishBlockV2jsonpublishBlockV2sszWhich issues(s) does this PR fix?
part of #12248