Deneb: publish block v1 ssz#12622
Merged
james-prysm merged 1 commit intodeneb-integrationfrom Jul 17, 2023
Merged
Conversation
james-prysm
force-pushed
the
deneb-publish-v1-ssz
branch
3 times, most recently
from
2d07b5b to
c939831
Compare
james-prysm
requested review from
kasey,
rauljordan,
rkapka and
terencechain
and removed request for
a team and
prestonvanloon
rkapka
reviewed
Jul 17, 2023
| } | ||
| blindedBlock, err := migration.BlindedDenebToV1Alpha1SignedBlock(blkContent.SignedBlindedBlock) | ||
| if err != nil { | ||
| return nil, status.Errorf(codes.InvalidArgument, "Submitted block is not blinded: %v", err) |
Contributor
Author
There was a problem hiding this comment.
hmm I think this should be right , instead of checking the is blinded function it's trying to migrate the type but if it's empty or doesn't marshal correctly I think we can say this. what do you think.
| _, err = server.SubmitBlindedBlockSSZ(sszCtx, blockReq) | ||
| assert.NotNil(t, err) | ||
| }) | ||
| t.Run("Deneb", func(t *testing.T) { |
Contributor
There was a problem hiding this comment.
You should add a Deneb full test case
james-prysm
force-pushed
the
deneb-publish-v1-ssz
branch
from
c939831 to
aae17b3
Compare
james-prysm
force-pushed
the
deneb-publish-v1-ssz
branch
from
aae17b3 to
f676ee7
Compare
rkapka
approved these changes
Jul 17, 2023
kasey
pushed a commit
that referenced
this pull request
Jul 20, 2023
james-prysm
added a commit
that referenced
this pull request
Aug 4, 2023
terencechain
pushed a commit
that referenced
this pull request
Aug 16, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 21, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 22, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 22, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 22, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 23, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 23, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 23, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 24, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 30, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 30, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
implements the following apis for deneb
Which issues(s) does this PR fix?
part of #12248