Deneb: get-blobs beacon api#12603
Merged
james-prysm merged 1 commit intodeneb-integrationfrom Jul 10, 2023
Merged
Conversation
james-prysm
requested review from
potuz,
rauljordan,
saolyn and
terencechain
and removed request for
a team
terencechain
approved these changes
Jul 7, 2023
Comment on lines
+162
to
+172
| resp.Data[i] = &Sidecar{ | ||
| BlockRoot: hexutil.Encode(sc.BlockRoot), | ||
| Index: strconv.FormatUint(sc.Index, 10), | ||
| Slot: strconv.FormatUint(uint64(sc.Slot), 10), | ||
| BlockParentRoot: hexutil.Encode(sc.BlockParentRoot), | ||
| ProposerIndex: strconv.FormatUint(uint64(sc.ProposerIndex), 10), | ||
| Blob: hexutil.Encode(sc.Blob), | ||
| KZGCommitment: hexutil.Encode(sc.KzgCommitment), | ||
| KZGProof: hexutil.Encode(sc.KzgProof), | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
I dont know what the best practice is here and whether we need to copy. Lgtm otherwise
Contributor
Author
There was a problem hiding this comment.
lets keep an eye out on it in testing. we have a few more PRs that will need to touch this too will keep an eyeout on ssz
james-prysm
force-pushed
the
deneb-get-blobs
branch
2 times, most recently
from
5452e77 to
7137fe9
Compare
james-prysm
force-pushed
the
deneb-get-blobs
branch
from
7137fe9 to
78c3464
Compare
kasey
pushed a commit
that referenced
this pull request
Jul 20, 2023
james-prysm
added a commit
that referenced
this pull request
Aug 4, 2023
terencechain
pushed a commit
that referenced
this pull request
Aug 16, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 21, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 22, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 22, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 22, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 23, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 23, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 23, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 24, 2023
kasey
added a commit
that referenced
this pull request
Aug 24, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 30, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 30, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
migrating get blob beacon api work from eip4844 to deneb-integration.
note: does not include ssz in PR.