feat: add builder override#12601
Merged
terencechain merged 2 commits intodeneb-integrationfrom Jul 22, 2023
Merged
Conversation
terencechain
requested review from
james-prysm,
nisdas and
saolyn
and removed request for
a team
terencechain
force-pushed
the
builder-override
branch
3 times, most recently
from
e927c39 to
1fa319c
Compare
rkapka
reviewed
Jul 7, 2023
| }() | ||
|
|
||
| localPayload, blobsBundle, err := vs.getLocalPayloadAndBlobs(ctx, sBlk.Block(), head) | ||
| localPayload, blobsBundle, override, err := vs.getLocalPayloadAndBlobs(ctx, sBlk.Block(), head) |
Contributor
There was a problem hiding this comment.
Can you rename override to overrideBuilder? Currently from the variable name it's not clear what we are overriding.
rkapka
reviewed
Jul 7, 2023
| copy(pid[:], payloadId[:]) | ||
| payloadIDCacheHit.Inc() | ||
| payload, blobsBundle, err := vs.ExecutionEngineCaller.GetPayload(ctx, pid, slot) | ||
| payload, blobsBundle, override, err := vs.ExecutionEngineCaller.GetPayload(ctx, pid, slot) |
Contributor
There was a problem hiding this comment.
Same here: override --> overrideBuilder
rkapka
approved these changes
Jul 7, 2023
terencechain
force-pushed
the
builder-override
branch
2 times, most recently
from
9b3a455 to
eb1fa64
Compare
terencechain
force-pushed
the
builder-override
branch
from
eb1fa64 to
7335e84
Compare
james-prysm
pushed a commit
that referenced
this pull request
Aug 4, 2023
terencechain
added a commit
that referenced
this pull request
Aug 16, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 21, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 22, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 22, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 22, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 23, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 23, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 23, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 24, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 30, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 30, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds builder override capability as specified in: ethereum/execution-apis#425
In summary, it uses the
BuilderOverrideflag to favor the local block over the builder one by adding a boolean parameter. Another way to do this is to encapsulate override in the execution data interface which seems like an overkill