Validate blobs feature#12574
Merged
terencechain merged 4 commits intodeneb-integrationfrom Aug 3, 2023
Merged
Conversation
potuz
requested review from
james-prysm,
kasey and
rauljordan
and removed request for
a team
potuz
force-pushed
the
validate-blobs-feature
branch
from
049445c to
132fbcc
Compare
Comment on lines
+671
to
+527
| sidecars, err := s.cfg.BeaconDB.BlobSidecarsByRoot(ctx, root) | ||
| if err != nil { | ||
| return errors.Wrap(err, "could not get blob sidecars") | ||
| } |
Collaborator
There was a problem hiding this comment.
What happens if the sidecars haven't arrived or one of them is missing at this point? What can information can I provide you from sync service or db service to get you to make the right move (wait)
potuz
force-pushed
the
validate-blobs-feature
branch
2 times, most recently
from
63404af to
ad72215
Compare
terencechain
force-pushed
the
deneb-integration
branch
from
aaeda1b to
dd3e166
Compare
potuz
force-pushed
the
validate-blobs-feature
branch
2 times, most recently
from
d2c194e to
8488fba
Compare
Member
|
Can you rebase and/or fix this branch? |
potuz
force-pushed
the
validate-blobs-feature
branch
2 times, most recently
from
735594e to
5761e38
Compare
potuz
force-pushed
the
validate-blobs-feature
branch
from
5761e38 to
2b99d6b
Compare
james-prysm
pushed a commit
that referenced
this pull request
Aug 4, 2023
terencechain
pushed a commit
that referenced
this pull request
Aug 4, 2023
terencechain
pushed a commit
that referenced
this pull request
Aug 16, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 21, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 22, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 22, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 22, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 23, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 23, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 23, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 24, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 30, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 30, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate blobs in the beacon chain-package