Merged
Conversation
terencechain
force-pushed
the
deneb-integration
branch
from
5ae0cae to
d3ee80e
Compare
james-prysm
force-pushed
the
deneb-get-block
branch
2 times, most recently
from
5da358c to
03b924c
Compare
james-prysm
requested review from
potuz,
prestonvanloon and
terencechain
and removed request for
a team
james-prysm
force-pushed
the
deneb-get-block
branch
2 times, most recently
from
e44fa58 to
1c71580
Compare
saolyn
reviewed
Jun 28, 2023
james-prysm
force-pushed
the
deneb-get-block
branch
from
1c71580 to
54fcd54
Compare
james-prysm
commented
Jun 28, 2023
| ssz_proto_files( | ||
| name = "ssz_proto_files", | ||
| srcs = [ | ||
| "beacon_block.proto", |
Contributor
Author
There was a problem hiding this comment.
want to make sure doing something like this makes sense, that beacon block can be moved here to make use of those variables for setting commitment length and blob length in proto
| TimeStamp string `json:"timestamp"` | ||
| ExtraData string `json:"extra_data" hex:"true"` | ||
| BaseFeePerGas string `json:"base_fee_per_gas" uint256:"true"` | ||
| ExcessDataGas string `json:"excess_data_gas" uint256:"true"` |
Collaborator
There was a problem hiding this comment.
Don't forget DataGasUsed field. Same with header
| Slot string `json:"slot"` | ||
| BlockParentRoot string `json:"block_parent_root" hex:"true"` | ||
| ProposerIndex string `json:"proposer_index"` | ||
| Blob string `json:"blob" hex:"true"` // pattern: "^0x[a-fA-F0-9]{262144}$" ssz-max:"4" |
Collaborator
There was a problem hiding this comment.
I don't think ssz-max:"4" comment is correct. This is just a single blob right?
proto/eth/v2/blobs.proto
Outdated
| } | ||
|
|
||
| message SignedBlindedBlobSidecar { | ||
| BlindedBlobSidecar message = 1 [(ethereum.eth.ext.ssz_max) = "4"]; |
Collaborator
There was a problem hiding this comment.
The max should be 6 now
there should be no max here
james-prysm
force-pushed
the
deneb-get-block
branch
from
54fcd54 to
005c393
Compare
terencechain
approved these changes
Jun 28, 2023
terencechain
pushed a commit
that referenced
this pull request
Jul 7, 2023
terencechain
pushed a commit
that referenced
this pull request
Jul 9, 2023
kasey
pushed a commit
that referenced
this pull request
Jul 20, 2023
james-prysm
added a commit
that referenced
this pull request
Aug 4, 2023
terencechain
pushed a commit
that referenced
this pull request
Aug 16, 2023
james-prysm
added a commit
that referenced
this pull request
Aug 16, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 21, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 22, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 22, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 22, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 23, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 23, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 23, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 24, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
james-prysm
added a commit
that referenced
this pull request
Aug 25, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 30, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 30, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
migrates the following APIs from eip4844 to deneb-integration
getBlockV2jsongetBlockV2sszgetBlindedBlockjsongetBlindedBlocksszpublishBlockjsonpublishBlockssz (will be handled in separate PR)publishBlindedBlockjsonpublishBlindedBlockssz (will be handled in separate PR)produceBlindedBlockjsonproduceBlindedBlockssz (will be handled in separate PR)produceBlockV2jsonproduceBlockV2ssz (will be handled in separate PR)Which issues(s) does this PR fix?
Fixes #
Other notes for review