feat(deneb): proposer rpc to handle builder flow#12554
Merged
terencechain merged 6 commits intodeneb-integrationfrom Jun 26, 2023
Merged
feat(deneb): proposer rpc to handle builder flow#12554terencechain merged 6 commits intodeneb-integrationfrom
terencechain merged 6 commits intodeneb-integrationfrom
Conversation
terencechain
force-pushed
the
builder-rpc
branch
from
a37b3e8 to
d5dfbc6
Compare
james-prysm
reviewed
Jun 21, 2023
| } | ||
| if len(b.Deneb.Blobs) > fieldparams.MaxBlobsPerBlock { | ||
| return nil, status.Errorf(codes.InvalidArgument, "Too many blobs in block: %d", len(b.Deneb.Blobs)) | ||
| if wasBlinded { |
Contributor
There was a problem hiding this comment.
I feel like there is a code smell around this, a lot of different arrays used, can't put my finger on how to clean it up just yet but some parts can be broken into its own function or cleaned up some way just for readability.
terencechain
force-pushed
the
builder-rpc
branch
from
47a1b2c to
d1284cc
Compare
terencechain
requested review from
kasey,
prestonvanloon and
rkapka
and removed request for
a team
terencechain
force-pushed
the
builder-rpc
branch
from
0bd8d4d to
db935ce
Compare
james-prysm
reviewed
Jun 23, 2023
| for i, blob := range b.Deneb.Blobs { | ||
| if err := vs.P2P.BroadcastBlob(ctx, blob.Message.Index, blob); err != nil { | ||
| log.WithError(err).Errorf("Could not broadcast blob index %d / %d", i, len(b.Deneb.Blobs)) | ||
| sidecar := make([]*ethpb.BlobSidecar, len(scs)) |
Contributor
There was a problem hiding this comment.
sidecar -> sidecars?
or maybe savableSidecars?
james-prysm
reviewed
Jun 23, 2023
| blk, err = unblinder.unblindBuilderBlock(ctx) | ||
| blind := unblinder.b.IsBlinded() // | ||
|
|
||
| blk, sidecars, err := unblinder.unblindBuilderBlock(ctx) |
Contributor
There was a problem hiding this comment.
sidecars -> signedSidecars?
or hmm unblindedSignedSidecars?
a bit verbose but I think it can get rid of some of the comments and the blind check below.
Collaborator
Author
There was a problem hiding this comment.
f5f9478, went with unblindedSidecars. Didn't think signed convey anything extra here
james-prysm
approved these changes
Jun 26, 2023
Contributor
james-prysm
left a comment
james-prysm
left a comment
There was a problem hiding this comment.
I think the logic makes sense, there's probably more improvements on readability and the creation of all those slices to do similar things has some kind of code smell to me, but I don't have great suggestions on improvement right now, I do think that maybe blinded variable can be removed in favor of checking if unblindedsidecars is not nil but that's not too much of an improvement.
terencechain
added a commit
that referenced
this pull request
Jun 27, 2023
james-prysm
pushed a commit
that referenced
this pull request
Jun 27, 2023
terencechain
added a commit
that referenced
this pull request
Jul 7, 2023
terencechain
added a commit
that referenced
this pull request
Jul 9, 2023
kasey
pushed a commit
that referenced
this pull request
Jul 20, 2023
james-prysm
pushed a commit
that referenced
this pull request
Aug 4, 2023
terencechain
added a commit
that referenced
this pull request
Aug 16, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 21, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 22, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 22, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 22, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 23, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 23, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 23, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 24, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 30, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 30, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the proposer RPC to handle builder flow for Deneb.
GetBeaconBlockhighlights:getBuilderPayloadreturnsblindBlobsBundleto align symmetric withgetLocalPayloadsetKzgCommitmentstakes inblindBlobsBundlealongsideblobsBundleand choose accordinglyblindBlobsBundleToSidecarsto convert blind bundles to blind sidecarsGenericBeaconBlock_BlindedDenebgets returned to the validator client is the block is blindProposeBeaconBlockhighlights:newUnblindertakes in blinded blobs to callSubmitBlindBlockunblindBlobsSidecarsto convert blind sidecars and full bundle to unblinded sidecarsunblindBuilderBlockreturns unblinded sidecars