test(e2e): deneb basic#12546
Merged
terencechain merged 20 commits intodeneb-integrationfrom Jul 14, 2023
Merged
Conversation
terencechain
requested review from
james-prysm,
kasey and
potuz
and removed request for
a team
Member
|
Fails to build |
kasey
force-pushed
the
deneb-e2e
branch
2 times, most recently
from
40d4adc to
95261a7
Compare
terencechain
force-pushed
the
deneb-integration
branch
from
5ae0cae to
d3ee80e
Compare
terencechain
force-pushed
the
deneb-e2e
branch
2 times, most recently
from
ccdb9aa to
e9faf97
Compare
terencechain
force-pushed
the
deneb-integration
branch
from
aaeda1b to
dd3e166
Compare
kasey
reviewed
Jul 12, 2023
| oldSlot := bytesutil.BytesToSlotBigEndian(oldSlotBytes) | ||
| if oldSlot >= slot { | ||
| return fmt.Errorf("attempted to save blob with slot %d but already have older blob with slot %d", slot, oldSlot) | ||
| } |
Collaborator
There was a problem hiding this comment.
I know this was a workaround for devnet, but is this behavior we want in prod? Presumably we protect this invariant as part of our circular buffer design, cc @rauljordan
kasey
reviewed
Jul 12, 2023
| WithField("bellatrix_fv", fmt.Sprintf("%#x", params.BeaconConfig().BellatrixForkVersion)). | ||
| WithField("capella_fv", fmt.Sprintf("%#x", params.BeaconConfig().CapellaForkVersion)). | ||
| WithField("deneb_fv", fmt.Sprintf("%#x", params.BeaconConfig().DenebForkVersion)). | ||
| Debug("InitializeDataMaps") |
Collaborator
There was a problem hiding this comment.
I think I added this while debugging rpc issues, we should remove it.
kasey
reviewed
Jul 12, 2023
| WithField("deneb", fmt.Sprintf("%#x", deneb)). | ||
| Debug("context type mapping") | ||
| ctxByteTableLogged = true | ||
| } |
kasey
reviewed
Jul 12, 2023
| // See https://github.com/prysmaticlabs/grpc-gateway/issues/2 | ||
| replace github.com/grpc-ecosystem/grpc-gateway/v2 => github.com/prysmaticlabs/grpc-gateway/v2 v2.3.1-0.20230315201114-09284ba20446 | ||
|
|
||
| replace github.com/ethereum/go-ethereum => github.com/MariusVanDerWijden/go-ethereum v1.8.22-0.20230626175218-2d586a9714d9 |
Collaborator
There was a problem hiding this comment.
do we want this in deneb-integration?
Collaborator
Author
There was a problem hiding this comment.
I think it's fine to have them in deneb-integration until geth's official release. Reason being it's more valuable to have e2e test and for devnet, we can just run directly instead of having to cut a new branch every time
rauljordan
approved these changes
Jul 13, 2023
Resolved issues in the following files with DeepSource Autofix: 1. beacon-chain/blockchain/receive_block.go 2. beacon-chain/cache/depositsnapshot/merkle_tree.go 3. beacon-chain/db/kv/blob.go 4. beacon-chain/db/kv/blocks.go 5. beacon-chain/db/kv/state.go 6. beacon-chain/p2p/pubsub_tracer.go 7. beacon-chain/sync/checkpoint/api.go 8. beacon-chain/sync/checkpoint/file.go 9. beacon-chain/sync/rpc_beacon_blocks_by_root.go 10. beacon-chain/sync/rpc_blob_sidecars_by_root_test.go 11. beacon-chain/sync/subscriber_blob_sidecar.go 12. beacon-chain/sync/validate_sync_committee_message.go 13. build/bazel/non_bazel.go 14. config/features/config.go 15. consensus-types/mock/block.go 16. container/leaky-bucket/heap_test.go 17. container/leaky-bucket/leakybucket_test.go 18. proto/engine/v1/json_marshal_unmarshal_test.go 19. validator/accounts/accounts_exit.go 20. validator/accounts/accounts_helper.go 21. validator/client/testutil/mock_validator.go 22. validator/client/validator.go 23. validator/client/validator_test.go 24. validator/keymanager/local/keymanager.go
This reverts commit 4ffbf43.
kasey
pushed a commit
that referenced
this pull request
Jul 20, 2023
james-prysm
pushed a commit
that referenced
this pull request
Aug 4, 2023
terencechain
added a commit
that referenced
this pull request
Aug 16, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 21, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 22, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 22, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 22, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 23, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 23, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 23, 2023
james-prysm
pushed a commit
that referenced
this pull request
Aug 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deneb e2e test