Update ProposeBeaconBlock Prysm RPC for Deneb (Non builder)#12495
Merged
terencechain merged 2 commits intodeneb-integrationfrom Jun 7, 2023
Merged
Update ProposeBeaconBlock Prysm RPC for Deneb (Non builder)#12495terencechain merged 2 commits intodeneb-integrationfrom
ProposeBeaconBlock Prysm RPC for Deneb (Non builder)#12495terencechain merged 2 commits intodeneb-integrationfrom
Conversation
terencechain
requested review from
james-prysm,
prestonvanloon and
saolyn
and removed request for
a team
james-prysm
reviewed
Jun 6, 2023
| return nil, fmt.Errorf("could not broadcast block: %v", err) | ||
| } | ||
|
|
||
| root, err := blk.Block().HashTreeRoot() |
Contributor
There was a problem hiding this comment.
why is this check after the broadcast?
Collaborator
Author
There was a problem hiding this comment.
It's not really a check, it calculates the root for logging, and we can remove the log. But it's also later used in ReceiveBlock anyway. Moving it after the broadcast to reduce latency before the gossip
james-prysm
reviewed
Jun 6, 2023
| scs := make([]*ethpb.BlobSidecar, len(b.Deneb.Blobs)) | ||
| for i, blob := range b.Deneb.Blobs { | ||
| if err := vs.P2P.BroadcastBlob(ctx, blob.Message.Index, blob); err != nil { | ||
| log.WithError(err).Error("Could not broadcast blob") |
Contributor
There was a problem hiding this comment.
can we log at which blob this message failed ? among the total blobs broadcasted?
james-prysm
reviewed
Jun 6, 2023
| if !ok { | ||
| return nil, status.Error(codes.Internal, "Could not cast block to Deneb") | ||
| } | ||
| scs := make([]*ethpb.BlobSidecar, len(b.Deneb.Blobs)) |
Contributor
There was a problem hiding this comment.
does this need a validation check on len for blobs, or does receiving handle that
Collaborator
Author
There was a problem hiding this comment.
I think that's a good check to have, I'll add it in
james-prysm
reviewed
Jun 6, 2023
| }).Debug("Broadcasting block") | ||
|
|
||
| if blk.Version() >= version.Deneb { | ||
| b, ok := req.GetBlock().(*ethpb.GenericSignedBeaconBlock_Deneb) |
Contributor
There was a problem hiding this comment.
This could still be blinded right? , it was unblinded above but the request block would still be possibly blinded. that being said if it was blinded the blobs would also need to be unblinded below.
Collaborator
Author
There was a problem hiding this comment.
Right, I'm not handling the blinded logic in this PR. I'll clarify this in the title
terencechain
changed the title
ProposeBeaconBlock Prysm RPC for DenebProposeBeaconBlock Prysm RPC for Deneb (Non builder)
james-prysm
approved these changes
Jun 7, 2023
terencechain
added a commit
that referenced
this pull request
Jun 7, 2023
james-prysm
pushed a commit
that referenced
this pull request
Jun 7, 2023
terencechain
added a commit
that referenced
this pull request
Jun 12, 2023
terencechain
added a commit
that referenced
this pull request
Jun 12, 2023
terencechain
added a commit
that referenced
this pull request
Jun 16, 2023
terencechain
added a commit
that referenced
this pull request
Jun 27, 2023
terencechain
added a commit
that referenced
this pull request
Jul 7, 2023
terencechain
added a commit
that referenced
this pull request
Jul 9, 2023
terencechain
added a commit
that referenced
this pull request
Jul 10, 2023
kasey
pushed a commit
that referenced
this pull request
Jul 20, 2023
james-prysm
pushed a commit
that referenced
this pull request
Aug 4, 2023
terencechain
added a commit
that referenced
this pull request
Aug 16, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 21, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 22, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 22, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 22, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 23, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 23, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 23, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 24, 2023
kasey
added a commit
that referenced
this pull request
Aug 24, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 30, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 30, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
ProposeBeaconBlockabsorbsproposeGenericBeaconBlock.proposeGenericBeaconBlockis becoming harder to maintain.