Skip to content

Add Deneb upgrade function#12433

Merged
terencechain merged 4 commits intodeneb-integrationfrom
deneb-st-transition
May 23, 2023
Merged

Add Deneb upgrade function#12433
terencechain merged 4 commits intodeneb-integrationfrom
deneb-st-transition

Conversation

@terencechain
Copy link
Collaborator

@terencechain terencechain commented May 19, 2023

Add Deneb upgrade function

  • NewGenesisBlockForState returns Deneb state
  • UpgradeToDeneb upgrades Capella state to deneb
  • CanUpgradeToDeneb returns true if it's Deneb epoch
  • ProcessSlots and ReplayProcessSlots can upgrade to Deneb
  • Add spec test for upgrade

@terencechain terencechain self-assigned this May 19, 2023
@terencechain terencechain requested a review from a team as a code owner May 19, 2023 19:19
@terencechain terencechain requested review from kasey, potuz and saolyn and removed request for a team May 19, 2023 19:19
@terencechain terencechain force-pushed the deneb-st-transition branch from 035235d to e9e172d Compare May 19, 2023 19:20
@kasey kasey force-pushed the deneb-integration branch from ca11e4a to 220beca Compare May 22, 2023 16:43
@kasey kasey requested a review from prestonvanloon as a code owner May 22, 2023 16:43
@terencechain terencechain force-pushed the deneb-st-transition branch from e9e172d to aa26c6d Compare May 23, 2023 16:02
james-prysm
james-prysm reviewed May 23, 2023
View reviewed changes
testing/spectest/mainnet/deneb/fork_helper/upgrade_to_deneb_test.go Outdated
"github.com/prysmaticlabs/prysm/v4/testing/spectest/shared/deneb/fork"
)

func TestMainnet_Deneb_UpgradeToCapella(t *testing.T) {
Copy link
Contributor

@james-prysm james-prysm May 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we just call this TestMainnet_UpgradeToDeneb

james-prysm
james-prysm reviewed May 23, 2023
View reviewed changes
testing/spectest/minimal/deneb/fork/upgrade_to_deneb_test.go Outdated
"github.com/prysmaticlabs/prysm/v4/testing/spectest/shared/deneb/fork"
)

func TestMinimal_Deneb_UpgradeToDeneb(t *testing.T) {
Copy link
Contributor

@james-prysm james-prysm May 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here do we need the Deneb_UpgradeToDeneb, can it just be UpgradeToDeneb

james-prysm
james-prysm approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@james-prysm james-prysm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@terencechain terencechain merged commit 0166a25 into deneb-integration May 23, 2023
@terencechain terencechain deleted the deneb-st-transition branch May 23, 2023 17:33
terencechain added a commit that referenced this pull request May 23, 2023
@terencechain
Add Deneb upgrade function (#12433)
35f2e33
james-prysm pushed a commit that referenced this pull request May 23, 2023
@terencechain @james-prysm
Add Deneb upgrade function (#12433)
c9316b3
terencechain added a commit that referenced this pull request May 26, 2023
@terencechain
Add Deneb upgrade function (#12433)
d4fa07b
terencechain added a commit that referenced this pull request May 31, 2023
@terencechain
Add Deneb upgrade function (#12433)
aafb7d5
terencechain added a commit that referenced this pull request Jun 7, 2023
@terencechain
Add Deneb upgrade function (#12433)
3218493
terencechain added a commit that referenced this pull request Jun 12, 2023
@terencechain
Add Deneb upgrade function (#12433)
677b782
terencechain added a commit that referenced this pull request Jun 12, 2023
@terencechain
Add Deneb upgrade function (#12433)
748f7e3
terencechain added a commit that referenced this pull request Jun 16, 2023
@terencechain
Add Deneb upgrade function (#12433)
b12def3
terencechain added a commit that referenced this pull request Jun 27, 2023
@terencechain
Add Deneb upgrade function (#12433)
d0a8254
terencechain added a commit that referenced this pull request Jul 7, 2023
@terencechain
Add Deneb upgrade function (#12433)
bead0c6
terencechain added a commit that referenced this pull request Jul 9, 2023
@terencechain
Add Deneb upgrade function (#12433)
4575956
terencechain added a commit that referenced this pull request Jul 10, 2023
@terencechain
Add Deneb upgrade function (#12433)
9a63be8
kasey pushed a commit that referenced this pull request Jul 20, 2023
@terencechain @kasey
Add Deneb upgrade function (#12433)
91895a0
james-prysm pushed a commit that referenced this pull request Aug 4, 2023
@terencechain @james-prysm
Add Deneb upgrade function (#12433)
c13dec4
terencechain added a commit that referenced this pull request Aug 16, 2023
@terencechain
Add Deneb upgrade function (#12433)
7399774
kasey pushed a commit that referenced this pull request Aug 21, 2023
@terencechain @kasey
Add Deneb upgrade function (#12433)
a988c14
kasey pushed a commit that referenced this pull request Aug 22, 2023
@terencechain @kasey
Add Deneb upgrade function (#12433)
9455d8c
kasey pushed a commit that referenced this pull request Aug 22, 2023
@terencechain @kasey
Add Deneb upgrade function (#12433)
d8c7742
kasey pushed a commit that referenced this pull request Aug 22, 2023
@terencechain @kasey
Add Deneb upgrade function (#12433)
2b2f3b0
kasey pushed a commit that referenced this pull request Aug 23, 2023
@terencechain @kasey
Add Deneb upgrade function (#12433)
dc594fc
kasey pushed a commit that referenced this pull request Aug 23, 2023
@terencechain @kasey
Add Deneb upgrade function (#12433)
51a48e6
kasey pushed a commit that referenced this pull request Aug 23, 2023
@terencechain @kasey
Add Deneb upgrade function (#12433)
0e46962
kasey pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @kasey
Add Deneb upgrade function (#12433)
1d553b5
kasey pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @kasey
Add Deneb upgrade function (#12433)
d94eaa5
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
Add Deneb upgrade function (#12433)
f9279c6
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
Add Deneb upgrade function (#12433)
7131050
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
Add Deneb upgrade function (#12433)
01b482a
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
Add Deneb upgrade function (#12433)
f822c57
james-prysm pushed a commit that referenced this pull request Aug 25, 2023
@terencechain @james-prysm
Add Deneb upgrade function (#12433)
aa3c903
prestonvanloon pushed a commit that referenced this pull request Aug 30, 2023
@terencechain @prestonvanloon
Add Deneb upgrade function (#12433)
642d6dd
prestonvanloon pushed a commit that referenced this pull request Aug 30, 2023
@terencechain @prestonvanloon
Add Deneb upgrade function (#12433)
57d6aa6
prestonvanloon pushed a commit that referenced this pull request Aug 31, 2023
@terencechain @prestonvanloon
Add Deneb upgrade function (#12433)
e0c6939
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@james-prysm james-prysm james-prysm approved these changes

@kasey kasey Awaiting requested review from kasey kasey was automatically assigned from prysmaticlabs/core-team

@saolyn saolyn Awaiting requested review from saolyn saolyn was automatically assigned from prysmaticlabs/core-team

@potuz potuz Awaiting requested review from potuz potuz was automatically assigned from prysmaticlabs/core-team

@prestonvanloon prestonvanloon Awaiting requested review from prestonvanloon

Assignees

@terencechain terencechain

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@terencechain @james-prysm

Comments