Add validator index with Withdrawal pb#11563
Merged
prylabs-bulldozer[bot] merged 5 commits intodevelopfrom Oct 22, 2022
Merged
Conversation
potuz
requested changes
Oct 21, 2022
Contributor
potuz
left a comment
potuz
left a comment
There was a problem hiding this comment.
I think the tests in state-native/setters_withdrawal_tests.go and similar need to be changed to account for this field
potuz
approved these changes
Oct 21, 2022
rauljordan
approved these changes
Oct 21, 2022
prestonvanloon
previously requested changes
Oct 21, 2022
Comment on lines
+135
to
143
| // Validator index for the withdrawal | ||
| uint64 validator_index = 2 [(ethereum.eth.ext.cast_type) = "github.com/prysmaticlabs/prysm/v3/consensus-types/primitives.ValidatorIndex"]; | ||
|
|
||
| // The execution address receiving the funds | ||
| bytes execution_address = 2 [(ethereum.eth.ext.ssz_size) = "20"]; | ||
| bytes execution_address = 3 [(ethereum.eth.ext.ssz_size) = "20"]; | ||
|
|
||
| // The withdrawn amount in Gwei | ||
| uint64 amount = 3; | ||
| uint64 amount = 4; | ||
| } |
Member
There was a problem hiding this comment.
Do not change IDs. This is not going to be backwards compatible with the previous version.
Contributor
There was a problem hiding this comment.
what do you mean? there's no previous version, the spec is in flux
Member
There was a problem hiding this comment.
What I mean is that we should not be changing proto IDs. In this case, it seems like we can call it out as something that has not be implemented yet so it is safe to change, but it has to be explicit so that we don't develop the habit of changing proto IDs like this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Spec change
What does this PR do? Why is it needed?
In ethereum/consensus-specs#3050, the validator index with added to
Withdrawalso we need to follow. I don't thinkwithdraw_balancefunction has been implemented so no change there. This is an early version of the consensus container definition so frequent changes are expected. This is not used through out consensus yet