Implement optimistic sync spectests #11391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potuz
force-pushed
the
optimistic_sync_spectests
branch
from
75317a9 to
d793eed
Compare
potuz
force-pushed
the
optimistic_sync_spectests
branch
from
d793eed to
d32e676
Compare
potuz
changed the title
Comment on lines
+36
to
+38
| if err != nil { | ||
| return nil, "" | ||
| } |
Collaborator
There was a problem hiding this comment.
Can you explain this change? or even better add a comment
Collaborator
There was a problem hiding this comment.
Addressed offline, this is due to folder changes
Comment on lines
+36
to
+38
| testFolders, _ := utils.TestFolders(t, config, version.String(fork), basePath) | ||
| if testFolders == nil { | ||
| return |
Collaborator
There was a problem hiding this comment.
I wonder if t.Fatal is better than return here to eliminate false positives
terencechain
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement ethereum/consensus-specs#2982
The semantics of thevalidtests in forkchoice and sync is different this is why we fail currently, if that is changed the tests pass.Passing spectests as of 09/11.