Add mainnet merge epoch and ttd #11207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
changed the title
rauljordan
reviewed
Aug 17, 2022
| // Placeholder for the merge epoch until it is decided | ||
| mainnetBellatrixForkEpoch = math.MaxUint64 | ||
| // Bellatrix Fork Epoch for mainnet config. | ||
| mainnetBellatrixForkEpoch = 144896 // Sept 6, 2022, 11:34:47am UTC |
Contributor
There was a problem hiding this comment.
Checks out. Did
genesis_time=1606824023
bellatrix_fork_epoch=144896
seconds_since_genesis=bellatrix_fork_epoch3212
genesis_time+seconds_since_genesis=1662464087
Put it into a unix converter and got
rauljordan
approved these changes
Aug 17, 2022
Contributor
rauljordan
left a comment
rauljordan
left a comment
There was a problem hiding this comment.
Confirmed the TTD and epoch according to spec. Everything checks out! Will need someone else to also approve diligently before merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added numbers for the Bellatrix epoch and TTD as per ethereum/consensus-specs#2969
Updated spec tests to rc2
Wen merge 🐼