Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion beacon-chain/core/altair/epoch_precompute.go
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ func AttestationsDelta(beaconState state.BeaconState, bal *precompute.Balance, v
case version.Altair:
inactivityDenominator = bias * cfg.InactivityPenaltyQuotientAltair
case version.Bellatrix:
inactivityDenominator = bias * cfg.InactivityPenaltyQuotientMerge
inactivityDenominator = bias * cfg.InactivityPenaltyQuotientBellatrix
default:
return nil, nil, errors.Errorf("invalid state type version: %T", beaconState.Version())
}
Expand Down
2 changes: 1 addition & 1 deletion beacon-chain/core/altair/transition.go
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ func ProcessEpoch(ctx context.Context, state state.BeaconState) (state.BeaconSta
return nil, err
}
case version.Bellatrix:
state, err = e.ProcessSlashings(state, cfg.ProportionalSlashingMultiplierMerge)
state, err = e.ProcessSlashings(state, cfg.ProportionalSlashingMultiplierBellatrix)
if err != nil {
return nil, err
}
Expand Down
2 changes: 1 addition & 1 deletion beacon-chain/core/altair/transition_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ func TestProcessEpoch_CanProcess(t *testing.T) {
}

func TestProcessEpoch_CanProcessBellatrix(t *testing.T) {
st, _ := util.DeterministicGenesisStateMerge(t, params.BeaconConfig().MaxValidatorsPerCommittee)
st, _ := util.DeterministicGenesisStateBellatrix(t, params.BeaconConfig().MaxValidatorsPerCommittee)
require.NoError(t, st.SetSlot(10*params.BeaconConfig().SlotsPerEpoch))
newState, err := altair.ProcessEpoch(context.Background(), st)
require.NoError(t, err)
Expand Down
2 changes: 1 addition & 1 deletion beacon-chain/core/blocks/attester_slashing.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ func ProcessAttesterSlashing(
case beaconState.Version() == version.Altair:
slashingQuotient = cfg.MinSlashingPenaltyQuotientAltair
case beaconState.Version() == version.Bellatrix:
slashingQuotient = cfg.MinSlashingPenaltyQuotientMerge
slashingQuotient = cfg.MinSlashingPenaltyQuotientBellatrix
default:
return nil, errors.New("unknown state version")
}
Expand Down
2 changes: 1 addition & 1 deletion beacon-chain/core/blocks/attester_slashing_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ func TestProcessAttesterSlashings_AppliesCorrectStatusAltair(t *testing.T) {
}

func TestProcessAttesterSlashings_AppliesCorrectStatusBellatrix(t *testing.T) {
beaconState, privKeys := util.DeterministicGenesisStateMerge(t, 100)
beaconState, privKeys := util.DeterministicGenesisStateBellatrix(t, 100)
for _, vv := range beaconState.Validators() {
vv.WithdrawableEpoch = types.Epoch(params.BeaconConfig().SlotsPerEpoch)
}
Expand Down
2 changes: 1 addition & 1 deletion beacon-chain/core/blocks/payload.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import (
"github.com/prysmaticlabs/prysm/time/slots"
)

// MergeComplete returns true if the transition to merge has completed.
// MergeComplete returns true if the transition to Bellatrix has completed.
// Meaning the payload header in beacon state is not `ExecutionPayloadHeader()` (i.e. not empty).
//
// Spec code:
Expand Down
22 changes: 11 additions & 11 deletions beacon-chain/core/blocks/payload_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ func Test_MergeComplete(t *testing.T) {
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
st, _ := util.DeterministicGenesisStateMerge(t, 1)
st, _ := util.DeterministicGenesisStateBellatrix(t, 1)
require.NoError(t, st.SetLatestExecutionPayloadHeader(tt.payload))
got, err := blocks.MergeComplete(st)
require.NoError(t, err)
Expand Down Expand Up @@ -334,11 +334,11 @@ func Test_MergeBlock(t *testing.T) {
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
st, _ := util.DeterministicGenesisStateMerge(t, 1)
st, _ := util.DeterministicGenesisStateBellatrix(t, 1)
require.NoError(t, st.SetLatestExecutionPayloadHeader(tt.header))
blk := util.NewBeaconBlockMerge()
blk := util.NewBeaconBlockBellatrix()
blk.Block.Body.ExecutionPayload = tt.payload
body, err := wrapper.WrappedMergeBeaconBlockBody(blk.Block.Body)
body, err := wrapper.WrappedBellatrixBeaconBlockBody(blk.Block.Body)
require.NoError(t, err)
got, err := blocks.IsMergeBlock(st, body)
require.NoError(t, err)
Expand Down Expand Up @@ -399,11 +399,11 @@ func Test_ExecutionEnabled(t *testing.T) {
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
st, _ := util.DeterministicGenesisStateMerge(t, 1)
st, _ := util.DeterministicGenesisStateBellatrix(t, 1)
require.NoError(t, st.SetLatestExecutionPayloadHeader(tt.header))
blk := util.NewBeaconBlockMerge()
blk := util.NewBeaconBlockBellatrix()
blk.Block.Body.ExecutionPayload = tt.payload
body, err := wrapper.WrappedMergeBeaconBlockBody(blk.Block.Body)
body, err := wrapper.WrappedBellatrixBeaconBlockBody(blk.Block.Body)
require.NoError(t, err)
got, err := blocks.ExecutionEnabled(st, body)
require.NoError(t, err)
Expand Down Expand Up @@ -458,7 +458,7 @@ func Test_ValidatePayloadWhenMergeCompletes(t *testing.T) {
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
st, _ := util.DeterministicGenesisStateMerge(t, 1)
st, _ := util.DeterministicGenesisStateBellatrix(t, 1)
require.NoError(t, st.SetLatestExecutionPayloadHeader(tt.header))
err := blocks.ValidatePayloadWhenMergeCompletes(st, tt.payload)
if err != nil {
Expand All @@ -471,7 +471,7 @@ func Test_ValidatePayloadWhenMergeCompletes(t *testing.T) {
}

func Test_ValidatePayload(t *testing.T) {
st, _ := util.DeterministicGenesisStateMerge(t, 1)
st, _ := util.DeterministicGenesisStateBellatrix(t, 1)
random, err := helpers.RandaoMix(st, time.CurrentEpoch(st))
require.NoError(t, err)
ts, err := slots.ToTime(st.GenesisTime(), st.Slot())
Expand Down Expand Up @@ -519,7 +519,7 @@ func Test_ValidatePayload(t *testing.T) {
}

func Test_ProcessPayload(t *testing.T) {
st, _ := util.DeterministicGenesisStateMerge(t, 1)
st, _ := util.DeterministicGenesisStateBellatrix(t, 1)
random, err := helpers.RandaoMix(st, time.CurrentEpoch(st))
require.NoError(t, err)
ts, err := slots.ToTime(st.GenesisTime(), st.Slot())
Expand Down Expand Up @@ -611,7 +611,7 @@ func Test_PayloadToHeader(t *testing.T) {
}

func BenchmarkBellatrixComplete(b *testing.B) {
st, _ := util.DeterministicGenesisStateMerge(b, 1)
st, _ := util.DeterministicGenesisStateBellatrix(b, 1)
require.NoError(b, st.SetLatestExecutionPayloadHeader(emptyPayloadHeader()))

b.ResetTimer()
Expand Down
2 changes: 1 addition & 1 deletion beacon-chain/core/blocks/proposer_slashing.go
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ func ProcessProposerSlashing(
case beaconState.Version() == version.Altair:
slashingQuotient = cfg.MinSlashingPenaltyQuotientAltair
case beaconState.Version() == version.Bellatrix:
slashingQuotient = cfg.MinSlashingPenaltyQuotientMerge
slashingQuotient = cfg.MinSlashingPenaltyQuotientBellatrix
default:
return nil, errors.New("unknown state version")
}
Expand Down
2 changes: 1 addition & 1 deletion beacon-chain/core/blocks/proposer_slashing_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ func TestProcessProposerSlashings_AppliesCorrectStatusAltair(t *testing.T) {
func TestProcessProposerSlashings_AppliesCorrectStatusBellatrix(t *testing.T) {
// We test the case when data is correct and verify the validator
// registry has been updated.
beaconState, privKeys := util.DeterministicGenesisStateMerge(t, 100)
beaconState, privKeys := util.DeterministicGenesisStateBellatrix(t, 100)
proposerIdx := types.ValidatorIndex(1)

header1 := &ethpb.SignedBeaconBlockHeader{
Expand Down
4 changes: 2 additions & 2 deletions beacon-chain/core/execution/upgrade.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ import (
ethpb "github.com/prysmaticlabs/prysm/proto/prysm/v1alpha1"
)

// UpgradeToMerge updates inputs a generic state to return the version Merge state.
// UpgradeToBellatrix updates inputs a generic state to return the version Bellatrix state.
// It inserts an empty `ExecutionPayloadHeader` into the state.
func UpgradeToMerge(ctx context.Context, state state.BeaconState) (state.BeaconState, error) {
func UpgradeToBellatrix(ctx context.Context, state state.BeaconState) (state.BeaconState, error) {
epoch := time.CurrentEpoch(state)

currentSyncCommittee, err := state.CurrentSyncCommittee()
Expand Down
2 changes: 1 addition & 1 deletion beacon-chain/core/execution/upgrade_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import (
func TestUpgradeToBellatrix(t *testing.T) {
st, _ := util.DeterministicGenesisStateAltair(t, params.BeaconConfig().MaxValidatorsPerCommittee)
preForkState := st.Copy()
mSt, err := execution.UpgradeToMerge(context.Background(), st)
mSt, err := execution.UpgradeToBellatrix(context.Background(), st)
require.NoError(t, err)

require.Equal(t, preForkState.GenesisTime(), mSt.GenesisTime())
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import (
)

func TestExecuteBellatrixStateTransitionNoVerify_FullProcess(t *testing.T) {
beaconState, privKeys := util.DeterministicGenesisStateMerge(t, 100)
beaconState, privKeys := util.DeterministicGenesisStateBellatrix(t, 100)

syncCommittee, err := altair.NextSyncCommittee(context.Background(), beaconState)
require.NoError(t, err)
Expand Down Expand Up @@ -57,7 +57,7 @@ func TestExecuteBellatrixStateTransitionNoVerify_FullProcess(t *testing.T) {
require.NoError(t, err)
proposerIdx, err := helpers.BeaconProposerIndex(context.Background(), nextSlotState)
require.NoError(t, err)
block := util.NewBeaconBlockMerge()
block := util.NewBeaconBlockBellatrix()
block.Block.ProposerIndex = proposerIdx
block.Block.Slot = beaconState.Slot() + 1
block.Block.ParentRoot = parentRoot[:]
Expand Down Expand Up @@ -91,7 +91,7 @@ func TestExecuteBellatrixStateTransitionNoVerify_FullProcess(t *testing.T) {
SyncCommitteeSignature: aggregatedSig,
}
block.Block.Body.SyncAggregate = syncAggregate
wsb, err := wrapper.WrappedMergeSignedBeaconBlock(block)
wsb, err := wrapper.WrappedBellatrixSignedBeaconBlock(block)
require.NoError(t, err)
stateRoot, err := transition.CalculateStateRoot(context.Background(), beaconState, wsb)
require.NoError(t, err)
Expand All @@ -102,7 +102,7 @@ func TestExecuteBellatrixStateTransitionNoVerify_FullProcess(t *testing.T) {
require.NoError(t, err)
block.Signature = sig.Marshal()

wsb, err = wrapper.WrappedMergeSignedBeaconBlock(block)
wsb, err = wrapper.WrappedBellatrixSignedBeaconBlock(block)
require.NoError(t, err)
set, _, err := transition.ExecuteStateTransitionNoVerifyAnySig(context.Background(), beaconState, wsb)
require.NoError(t, err)
Expand All @@ -112,7 +112,7 @@ func TestExecuteBellatrixStateTransitionNoVerify_FullProcess(t *testing.T) {
}

func TestExecuteBellatrixStateTransitionNoVerifySignature_CouldNotVerifyStateRoot(t *testing.T) {
beaconState, privKeys := util.DeterministicGenesisStateMerge(t, 100)
beaconState, privKeys := util.DeterministicGenesisStateBellatrix(t, 100)

syncCommittee, err := altair.NextSyncCommittee(context.Background(), beaconState)
require.NoError(t, err)
Expand Down Expand Up @@ -144,7 +144,7 @@ func TestExecuteBellatrixStateTransitionNoVerifySignature_CouldNotVerifyStateRoo
require.NoError(t, err)
proposerIdx, err := helpers.BeaconProposerIndex(context.Background(), nextSlotState)
require.NoError(t, err)
block := util.NewBeaconBlockMerge()
block := util.NewBeaconBlockBellatrix()
block.Block.ProposerIndex = proposerIdx
block.Block.Slot = beaconState.Slot() + 1
block.Block.ParentRoot = parentRoot[:]
Expand Down Expand Up @@ -179,7 +179,7 @@ func TestExecuteBellatrixStateTransitionNoVerifySignature_CouldNotVerifyStateRoo
}
block.Block.Body.SyncAggregate = syncAggregate

wsb, err := wrapper.WrappedMergeSignedBeaconBlock(block)
wsb, err := wrapper.WrappedBellatrixSignedBeaconBlock(block)
require.NoError(t, err)
stateRoot, err := transition.CalculateStateRoot(context.Background(), beaconState, wsb)
require.NoError(t, err)
Expand All @@ -191,14 +191,14 @@ func TestExecuteBellatrixStateTransitionNoVerifySignature_CouldNotVerifyStateRoo
block.Signature = sig.Marshal()

block.Block.StateRoot = bytesutil.PadTo([]byte{'a'}, 32)
wsb, err = wrapper.WrappedMergeSignedBeaconBlock(block)
wsb, err = wrapper.WrappedBellatrixSignedBeaconBlock(block)
require.NoError(t, err)
_, _, err = transition.ExecuteStateTransitionNoVerifyAnySig(context.Background(), beaconState, wsb)
require.ErrorContains(t, "could not validate state root", err)
}

func TestProcessEpoch_BadBalanceBellatrix(t *testing.T) {
s, _ := util.DeterministicGenesisStateMerge(t, 100)
s, _ := util.DeterministicGenesisStateBellatrix(t, 100)
assert.NoError(t, s.SetSlot(63))
assert.NoError(t, s.UpdateBalancesAtIndex(0, math.MaxUint64))
participation := byte(0)
Expand All @@ -219,15 +219,15 @@ func TestProcessEpoch_BadBalanceBellatrix(t *testing.T) {
}

func createFullBellatrixBlockWithOperations(t *testing.T) (state.BeaconState,
*ethpb.SignedBeaconBlockMerge) {
*ethpb.SignedBeaconBlockBellatrix) {
_, altairBlk := createFullAltairBlockWithOperations(t)
blk := &ethpb.SignedBeaconBlockMerge{
Block: &ethpb.BeaconBlockMerge{
blk := &ethpb.SignedBeaconBlockBellatrix{
Block: &ethpb.BeaconBlockBellatrix{
Slot: altairBlk.Block.Slot,
ProposerIndex: altairBlk.Block.ProposerIndex,
ParentRoot: altairBlk.Block.ParentRoot,
StateRoot: altairBlk.Block.StateRoot,
Body: &ethpb.BeaconBlockBodyMerge{
Body: &ethpb.BeaconBlockBodyBellatrix{
RandaoReveal: altairBlk.Block.Body.RandaoReveal,
Eth1Data: altairBlk.Block.Body.Eth1Data,
Graffiti: altairBlk.Block.Body.Graffiti,
Expand All @@ -253,6 +253,6 @@ func createFullBellatrixBlockWithOperations(t *testing.T) (state.BeaconState,
},
Signature: nil,
}
beaconState, _ := util.DeterministicGenesisStateMerge(t, 32)
beaconState, _ := util.DeterministicGenesisStateBellatrix(t, 32)
return beaconState, blk
}
2 changes: 1 addition & 1 deletion beacon-chain/core/transition/transition.go
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ func ProcessSlots(ctx context.Context, state state.BeaconState, slot types.Slot)
}

if time.CanUpgradeToBellatrix(state.Slot()) {
state, err = execution.UpgradeToMerge(ctx, state)
state, err = execution.UpgradeToBellatrix(ctx, state)
if err != nil {
tracing.AnnotateError(span, err)
return nil, err
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ func TestProcessOperationsNoVerifyAttsSigs_OK(t *testing.T) {

func TestProcessOperationsNoVerifyAttsSigsBellatrix_OK(t *testing.T) {
beaconState, block := createFullBellatrixBlockWithOperations(t)
wsb, err := wrapper.WrappedMergeSignedBeaconBlock(block)
wsb, err := wrapper.WrappedBellatrixSignedBeaconBlock(block)
require.NoError(t, err)
beaconState, err = transition.ProcessSlots(context.Background(), beaconState, wsb.Block().Slot())
require.NoError(t, err)
Expand Down
4 changes: 2 additions & 2 deletions beacon-chain/core/transition/transition_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,7 @@ func TestProcessSlots_OnlyBellatrixEpoch(t *testing.T) {
params.OverrideBeaconConfig(conf)
defer params.UseMainnetConfig()

st, _ := util.DeterministicGenesisStateMerge(t, params.BeaconConfig().MaxValidatorsPerCommittee)
st, _ := util.DeterministicGenesisStateBellatrix(t, params.BeaconConfig().MaxValidatorsPerCommittee)
require.NoError(t, st.SetSlot(params.BeaconConfig().SlotsPerEpoch*6))
require.Equal(t, version.Bellatrix, st.Version())
st, err := transition.ProcessSlots(context.Background(), st, params.BeaconConfig().SlotsPerEpoch*10)
Expand Down Expand Up @@ -588,7 +588,7 @@ func TestProcessSlots_OnlyBellatrixEpoch(t *testing.T) {
require.Equal(t, params.BeaconConfig().SyncCommitteeSize, uint64(len(sc.Pubkeys)))
}

func TestProcessSlots_ThroughMergeEpoch(t *testing.T) {
func TestProcessSlots_ThroughBellatrixEpoch(t *testing.T) {
transition.SkipSlotCache.Disable()
params.SetupTestConfigCleanup(t)
conf := params.BeaconConfig()
Expand Down
6 changes: 3 additions & 3 deletions beacon-chain/db/kv/blocks.go
Original file line number Diff line number Diff line change
Expand Up @@ -636,13 +636,13 @@ func unmarshalBlock(_ context.Context, enc []byte) (block.SignedBeaconBlock, err
return nil, err
}
return wrapper.WrappedAltairSignedBeaconBlock(rawBlock)
case hasMergeKey(enc):
rawBlock := &ethpb.SignedBeaconBlockMerge{}
case hasBellatrixKey(enc):
rawBlock := &ethpb.SignedBeaconBlockBellatrix{}
err := rawBlock.UnmarshalSSZ(enc[len(bellatrixKey):])
if err != nil {
return nil, err
}
return wrapper.WrappedMergeSignedBeaconBlock(rawBlock)
return wrapper.WrappedBellatrixSignedBeaconBlock(rawBlock)
default:
// Marshal block bytes to phase 0 beacon block.
rawBlock := &ethpb.SignedBeaconBlock{}
Expand Down
4 changes: 2 additions & 2 deletions beacon-chain/db/kv/blocks_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,12 @@ var blockTests = []struct {
{
name: "bellatrix",
newBlock: func(slot types.Slot, root []byte) (block.SignedBeaconBlock, error) {
b := util.NewBeaconBlockMerge()
b := util.NewBeaconBlockBellatrix()
b.Block.Slot = slot
if root != nil {
b.Block.ParentRoot = root
}
return wrapper.WrappedMergeSignedBeaconBlock(b)
return wrapper.WrappedBellatrixSignedBeaconBlock(b)
},
},
}
Expand Down
2 changes: 1 addition & 1 deletion beacon-chain/db/kv/key.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ func hasAltairKey(enc []byte) bool {
return bytes.Equal(enc[:len(altairKey)], altairKey)
}

func hasMergeKey(enc []byte) bool {
func hasBellatrixKey(enc []byte) bool {
if len(bellatrixKey) >= len(enc) {
return false
}
Expand Down
2 changes: 1 addition & 1 deletion beacon-chain/db/kv/state.go
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@ func (s *Store) unmarshalState(_ context.Context, enc []byte, validatorEntries [
}

switch {
case hasMergeKey(enc):
case hasBellatrixKey(enc):
// Marshal state bytes to altair beacon state.
protoState := &ethpb.BeaconStateBellatrix{}
if err := protoState.UnmarshalSSZ(enc[len(bellatrixKey):]); err != nil {
Expand Down
6 changes: 3 additions & 3 deletions beacon-chain/db/kv/state_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -795,7 +795,7 @@ func TestStateBellatrix_CanSaveRetrieveValidatorEntries(t *testing.T) {
require.Equal(t, false, db.HasState(context.Background(), r))

stateValidators := validators(10)
st, _ := util.DeterministicGenesisStateMerge(t, 20)
st, _ := util.DeterministicGenesisStateBellatrix(t, 20)
require.NoError(t, st.SetSlot(100))
require.NoError(t, st.SetValidators(stateValidators))

Expand Down Expand Up @@ -840,7 +840,7 @@ func TestBellatrixState_CanSaveRetrieve(t *testing.T) {

require.Equal(t, false, db.HasState(context.Background(), r))

st, _ := util.DeterministicGenesisStateMerge(t, 1)
st, _ := util.DeterministicGenesisStateBellatrix(t, 1)
require.NoError(t, st.SetSlot(100))

require.NoError(t, db.SaveState(context.Background(), st, r))
Expand All @@ -863,7 +863,7 @@ func TestBellatrixState_CanDelete(t *testing.T) {

require.Equal(t, false, db.HasState(context.Background(), r))

st, _ := util.DeterministicGenesisStateMerge(t, 1)
st, _ := util.DeterministicGenesisStateBellatrix(t, 1)
require.NoError(t, st.SetSlot(100))

require.NoError(t, db.SaveState(context.Background(), st, r))
Expand Down
Loading