Skip to content

Deploy tx timeout option#710

Merged
PlasmaPower merged 1 commit intoredo-devnet-reinit-1from
deploy-txtimeout-config
Jun 23, 2022
Merged

Deploy tx timeout option#710
PlasmaPower merged 1 commit intoredo-devnet-reinit-1from
deploy-txtimeout-config

Conversation

@rachel-bousfield
Copy link
Contributor

Adds a txtimeout cli option for specifying how long to wait for a transaction to be included in a block

@cla-bot cla-bot bot added the cla-signed label Jun 23, 2022
Copy link
Contributor

@hkalodner hkalodner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #710 (e2737f2) into redo-devnet-reinit-1 (067883e) will decrease coverage by 4.44%.
The diff coverage is 0.00%.

@@                   Coverage Diff                    @@
##           redo-devnet-reinit-1     #710      +/-   ##
========================================================
- Coverage                 52.07%   47.63%   -4.45%     
========================================================
  Files                       224      212      -12     
  Lines                     26539    22429    -4110     
  Branches                    489      489              
========================================================
- Hits                      13821    10684    -3137     
+ Misses                    11264    10287     -977     
- Partials                   1454     1458       +4     

Copy link
Contributor

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower merged commit 69381ca into redo-devnet-reinit-1 Jun 23, 2022
@PlasmaPower PlasmaPower deleted the deploy-txtimeout-config branch June 23, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants