Skip to content

refactor: sequencer inbox DAS changes#698

Merged
PlasmaPower merged 16 commits intorefactor-accumulator-flowfrom
refactor-sequencer-das
Jun 16, 2022
Merged

refactor: sequencer inbox DAS changes#698
PlasmaPower merged 16 commits intorefactor-accumulator-flowfrom
refactor-sequencer-das

Conversation

@fredlacs
Copy link
Contributor

@fredlacs fredlacs commented Jun 16, 2022

Refactored a couple things:

  • removed a calldata to memory copy when processing batches
  • removed low level assembly syntax
  • refactored batch data validation into a single modifier
  • removed overflow validation step which isn't needed in solidity >= 0.8
  • added a struct to track DAS keysets

@cla-bot cla-bot bot added the cla-signed label Jun 16, 2022
@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #698 (77923a0) into refactor-accumulator-flow (b8f66e1) will decrease coverage by 4.54%.
The diff coverage is 38.88%.

@@                      Coverage Diff                      @@
##           refactor-accumulator-flow     #698      +/-   ##
=============================================================
- Coverage                      52.01%   47.47%   -4.55%     
=============================================================
  Files                            224      213      -11     
  Lines                          26727    22690    -4037     
  Branches                         495      493       -2     
=============================================================
- Hits                           13901    10771    -3130     
+ Misses                         11380    10473     -907     
  Partials                        1446     1446              

@fredlacs fredlacs changed the title refactor: avoid calldata to memory copy in sequencer inbox when not a DAS batch refactor: sequencer inbox DAS changes Jun 16, 2022
Copy link
Contributor

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower merged commit e7b3d85 into refactor-accumulator-flow Jun 16, 2022
@PlasmaPower PlasmaPower deleted the refactor-sequencer-das branch June 16, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants