Change retryable refund calculation#654
Merged
rachel-bousfield merged 26 commits intoredo-devnet-reinit-1from Jun 23, 2022
Merged
Change retryable refund calculation#654rachel-bousfield merged 26 commits intoredo-devnet-reinit-1from
rachel-bousfield merged 26 commits intoredo-devnet-reinit-1from
Conversation
Codecov Report
@@ Coverage Diff @@
## redo-devnet-reinit-1 #654 +/- ##
========================================================
+ Coverage 47.68% 47.90% +0.22%
========================================================
Files 212 212
Lines 22422 22504 +82
Branches 489 489
========================================================
+ Hits 10691 10780 +89
+ Misses 10277 10271 -6
+ Partials 1454 1453 -1 |
gzeoneth
reviewed
Jun 2, 2022
gzeoneth
reviewed
Jun 2, 2022
arbos/tx_processor.go
Outdated
| } | ||
| submissionFeeRefund = arbmath.BigMin(submissionFeeRefund, availableRefund) | ||
| submissionFeeRefund = arbmath.BigMin(submissionFeeRefund, statedb.GetBalance(from)) | ||
| availableRefund.Sub(availableRefund, submissionFeeRefund) |
Member
There was a problem hiding this comment.
submissionFee is spent and submissionFeeRefund is refunded
so I think we should subtract by tx.MaxSubmissionFee instead
Suggested change
| availableRefund.Sub(availableRefund, submissionFeeRefund) | |
| availableRefund.Sub(availableRefund, tx.MaxSubmissionFee) |
Contributor
Author
There was a problem hiding this comment.
This code has been changed to charge the submission fee against the max refund first if possible
Contributor
|
Not sure if this would be the appropriate PR but we also discussed 2 changes related to these codepaths:
|
rachel-bousfield
changed the base branch from
devnet-reinit-1
to
redo-devnet-reinit-1
Merged
PlasmaPower
force-pushed
the
retryable-refund-changes
branch
from
bc80b6e to
c96a6e0
Compare
tsahee
pushed a commit
that referenced
this pull request
Jul 29, 2025
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A potential successor to #635. Pulls in: