[NIT-3121] Make uncompressed batch size limit configurable #3947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
❌ 5 Tests Failed:
View the top 3 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
Tristan-Wilson
requested changes
Nov 7, 2025
Member
Tristan-Wilson
left a comment
Tristan-Wilson
left a comment
There was a problem hiding this comment.
PR looks good but I had a comment on the geth PR which will probably change this one due to how to access the new decompression limit setting, so marking request changes.
…-uncompressed-batch-size-limit
Tristan-Wilson
previously approved these changes
Nov 12, 2025
tsahee
requested changes
Dec 5, 2025
Contributor
tsahee
left a comment
tsahee
left a comment
There was a problem hiding this comment.
sorry for the long delay. generally seems great
…-uncompressed-batch-size-limit # Conflicts: # cmd/replay/main.go
tsahee
previously requested changes
Dec 18, 2025
|
|
||
| tx, err := seqInbox.AddSequencerL2BatchFromOrigin8f111f3c(&sequencer, seqNum, batch, big.NewInt(1), common.Address{}, big.NewInt(0), big.NewInt(0)) | ||
| Require(t, err) | ||
| _, err = EnsureTxSucceeded(ctx, builder.L1.Client, tx) |
Contributor
There was a problem hiding this comment.
here, you can look at the receipt, search for the event SequencerBatchDelivered and extract from it seqMessageIndex. Then you can wait for this specific batch to be received instead of waiting for a new batch to be received
…-uncompressed-batch-size-limit # Conflicts: # arbnode/mel/extraction/message_extraction_function.go # arbnode/mel/extraction/message_extraction_function_test.go # arbnode/mel/runner/mel.go # cmd/pruning/pruning.go
…-uncompressed-batch-size-limit # Conflicts: # cmd/replay/main.go
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3947 +/- ##
==========================================
+ Coverage 33.35% 33.47% +0.11%
==========================================
Files 453 453
Lines 55536 55556 +20
==========================================
+ Hits 18524 18596 +72
+ Misses 33774 33729 -45
+ Partials 3238 3231 -7 |
…-uncompressed-batch-size-limit
Tristan-Wilson
approved these changes
Dec 19, 2025
pmikolajczyk41
dismissed
tsahee’s stale review
Offline, Tsahi wrote:
I added a comment about testing. It's small but I think it's exactly the sort of thing we should start to do more to make our tests less flaky. I left the design-approved comment. After it's solved, you can let anyone approve it, dismiss my review and merge.
The issue has been solved, thus dismissing.
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
pmikolajczyk41
deleted the
pmikolajczyk/nit-3121-uncompressed-batch-size-limit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We extend (Arbitrum) chain config with a new field describing limit on the uncompressed batch size (previously hardcoded to 16MB).
Note
Design decision: Instead of propagating individual limit values as bare integers between components, we pass the entire
params.ChainConfigstruct. This architectural decision is crucial for maintaining chain configuration integrity. By requiring access to the specific limit field only via the full parameters object, we explicitly guarantee that the value used is always sourced directly from the authoritative chain configuration. This mitigates the risk of developers accidentally (or intentionally) passing arbitrary values that are incompatible with the chain's agreed-upon settings.This limit value is used in two places:
BatchPosterOptsandBatchPosterstructs.ParseSequencerMessage.Related changes:
ArbitrumDevTestChainConfigin inbox fuzzing testsMessageExtractorwith chain params (I preferred to do this instead of extending MEL state as suggested in the Linear ticket)pulls in OffchainLabs/go-ethereum#571
closes NIT-3121