Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update config description for batch poster max batch size #2790

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

magicxyyz
Copy link
Contributor

Resolves NIT-2529

This PR updates config description for batch-poster.max-size and batch-poster.max-4844-batch-size to indicate that those are maximums of estimated compressed sizes.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Nov 15, 2024
@magicxyyz magicxyyz changed the title update config descritpion for batch poster max batch size update config description for batch poster max batch size Nov 15, 2024
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuacolvin0 joshuacolvin0 merged commit 36a7ab8 into master Nov 15, 2024
17 checks passed
@joshuacolvin0 joshuacolvin0 deleted the batch-poster-max-size-help branch November 15, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants