-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timeboosted information to broadcast feed #2695
Open
ganeshvanahalli
wants to merge
17
commits into
express-lane-timeboost
Choose a base branch
from
add-timeboosted-broadcastfeedmessage
base: express-lane-timeboost
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add timeboosted information to broadcast feed #2695
ganeshvanahalli
wants to merge
17
commits into
express-lane-timeboost
from
add-timeboosted-broadcastfeedmessage
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
label
Sep 24, 2024
ganeshvanahalli
requested review from
Tristan-Wilson,
gligneul and
amsanghi
September 24, 2024 12:49
Tristan-Wilson
requested changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good, just a few comments.
ganeshvanahalli
changed the title
Add timeboosted field to broadcast feed
Add timeboosted information to broadcast feed
Oct 2, 2024
Tristan-Wilson
requested changes
Oct 2, 2024
…BlockMetaData when updating message's BatchGasCost
Tristan-Wilson
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
s
Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new field
blockMetadata
to theBroadcastFeedMessage
struct that represents whether a particular transaction in the block was time-boosted or not.The field
blockMetadata
is an array of bytes and it starts with a 0 (version) followed by ceil(N/8) number of bytes where N is the number of txs in the block. Basicallyn
th bit of thek
th byte of blockMetadata byte array represents the status of8*(k-1)+(n+1)
th transaction, if its 1 means the tx was timeboosted else it wasn't.Example: if blockMetadata array viewed as bits is
00000000 01100101
then 2nd, 3rd, 6th and 8th transactions in the block were timeboosted.Resolves NIT-2779