Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NIT-2774] Enable external-signer for batch-poster with DA #2669

Merged
merged 10 commits into from
Sep 26, 2024

Conversation

gligneul
Copy link
Contributor

When running a batch-poster with anytrust, Nitro needs to load the batch-poster parent-chain wallet config to sign the DA messages even if an external signer is also being used.

Close NIT-2774

When running a batch-poster with anytrust, Nitro needs to load the
batch-poster parent-chain wallet config to sign the DA messages even if
an external signer is also being used.
@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Sep 12, 2024
@gligneul
Copy link
Contributor Author

Since this change is on a configuration on the nitro binary, it doesn't make sense to add a system test. I will test it manually with the nitro test node.

Copy link
Member

@eljobe eljobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gligneul
Copy link
Contributor Author

I tested this on the nitro test node using the code in the Anytrust PR and a mock external signer that I hacked based on the external signer unit test. In this configuration, I set both the node.batch-poster.data-poster.external-signer and node.batch-poster.parent-chain-wallet config options. (The Anytrust options were also set based on the Anytrust PR). I spun up the node, sent a transaction, and confirmed that the node posted a batch using the external signer.

I also created a follow-up ticket on Linear to add an external-signer option to the nitro test node.

@PlasmaPower PlasmaPower merged commit f549194 into master Sep 26, 2024
15 checks passed
@PlasmaPower PlasmaPower deleted the gligneul/external-signer-for-anytrust branch September 26, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants