Skip to content

[NIT-2437] Propogate error as reason while stopping flatTracer#307

Closed
amsanghi wants to merge 1 commit intomasterfrom
fix_error
Closed

[NIT-2437] Propogate error as reason while stopping flatTracer#307
amsanghi wants to merge 1 commit intomasterfrom
fix_error

Conversation

@amsanghi
Copy link
Copy Markdown
Contributor

@amsanghi amsanghi commented Apr 22, 2024

Thanks @tsahee for figuring out the issue!

@cla-bot cla-bot Bot added the s CLA signed label Apr 22, 2024
@amsanghi amsanghi requested a review from tsahee April 22, 2024 17:09
@amsanghi amsanghi marked this pull request as ready for review April 22, 2024 17:09
@amsanghi amsanghi changed the title Propogate error as reason while stopping flatTracer [NIT-2437] Propogate error as reason while stopping flatTracer Apr 22, 2024
Comment thread eth/tracers/native/call_flat.go
@PlasmaPower
Copy link
Copy Markdown
Contributor

Sorry I didn't see this PR. I made one copy-pasting Infura's new approach (which matches @tsahee's suggestion) here: #310

I'll close this one accordingly. Thanks for helping out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

s CLA signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants