This repository was archived by the owner on Nov 6, 2022. It is now read-only.
Return different result code on out-of-gas #580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachel-bousfield
approved these changes
Aug 17, 2021
Contributor
rachel-bousfield
left a comment
rachel-bousfield
left a comment
There was a problem hiding this comment.
Looks good to me, merging
| } else { | ||
| // Application code must have hit an error. | ||
| inErrorHandler = false; | ||
| let _ = evmCallStack_returnFromCall( |
Contributor
There was a problem hiding this comment.
Now that evmCallStack_returnFromCall may resolve the error handler, the debug((664, errInfo = 0)); from evmCallStack_callHitError may not occur. This shouldn't matter since we aren't consuming this on the node's side
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new transaction result code (16) to indicate that the transaction ran out of gas while executing. Previously ArbOS returned the result code for an ordinary revert (1) in this case.
Fixes #579