adapted code to be compatible with libQGLViewer >= 2.7.0#297
Merged
ahornung merged 1 commit intoOctoMap:develfrom Jun 10, 2020
expeditioneer:qglviewer
Merged
adapted code to be compatible with libQGLViewer >= 2.7.0#297ahornung merged 1 commit intoOctoMap:develfrom expeditioneer:qglviewer
ahornung merged 1 commit intoOctoMap:develfrom
expeditioneer:qglviewer
Conversation
ahornung
reviewed
Jun 9, 2020
| glPushAttrib(GL_ALL_ATTRIB_BITS); | ||
|
|
||
| glDisable(GL_COLOR_MATERIAL); | ||
| qglColor(foregroundColor()); |
Member
There was a problem hiding this comment.
Is this line intentionally removed?
Contributor
Author
There was a problem hiding this comment.
Yes, it it also from the deprecated QGLWidget Class, see https://doc.qt.io/qt-5/qglwidget.html#qglColor, and therefore no longer supported.
ahornung
reviewed
Jun 9, 2020
|
|
||
| void ViewerGui::on_action_bg_black_triggered() { | ||
| m_glwidget->setBackgroundColor( QColor(0,0,0) ); | ||
| m_glwidget->qglClearColor( m_glwidget->backgroundColor() ); |
Member
There was a problem hiding this comment.
So, this (and the similar changes below) is no longer necessary?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #194
libQGLViewer 2.7.0 was released on 15 Jun 2017
QGLViewer extends QOpenGLWidget instead of the deprecated QGLWidget
see release 2.7.0