Removed problematic INSTALL_NAME_DIR#262
Merged
ahornung merged 1 commit intoOctoMap:develfrom Dec 8, 2019
Merged
Conversation
30 tasks
Member
|
Yeah, it was added 8 years ago in this commit (contributed by a user): 5d5ef79 I never had a chance to actually test under MacOS, so if it works now better without it then I'm sure we can remove it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
INSTALL_NAME_DIRinterfered with CMake's install process. With it in place, linkage looked like this:This clearly doesn't look right - it has references the build directory rather than the install directory.
Upon removing
INSTALL_NAME_DIR, we get the much better looking:For the avoidance of doubt, here's what
@rpathis:I do note the comment saying that
INSTALL_NAME_DIR"seems to be necessary". Looking back, I couldn't find a precise reason why but it was added 8 years ago. CMake at that point had very poor install support on macOS - it didn't even know what an@rpathwas. Now it has very good support and you rarely need to worry about it.