-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd: move threshold check to CLI level #3297
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3297 +/- ##
==========================================
+ Coverage 57.60% 57.69% +0.08%
==========================================
Files 211 211
Lines 30604 30618 +14
==========================================
+ Hits 17629 17664 +35
+ Misses 11070 11047 -23
- Partials 1905 1907 +2 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
A recent commit introduced a misbehavior when omitting the optional
--threshold
flag ofcreate dkg
andcreate cluster
commands.Because the threshold configuration is tested before the threshold variable is assigned to the default value
ceil(2*n/3)
, the flag is not optional anymore.This PR fixes this bug by moving the checks at the CLI level and by updating the corresponding tests accordingly.
It also adds an input validation check on the
ThresholdSplit
andThresholdSplitInsecure
functions to ensure they are called with a threshold parameter greater than 1.category: bug
ticket: none