Skip to content

Conversation

Shubham-Patel07
Copy link
Contributor

@Shubham-Patel07 Shubham-Patel07 commented Oct 13, 2024

What kind of changes does this PR include?

  • Fixes or refactors
  • A new challenge
  • Additional documentation
  • Something else

Description

New challenge created for misconfiguration of docker secret in code.

Relations

Closes #811

Checklist:

  • All the contributions made are solely the work of me and my co-authors
  • I tested the changes in this PR (if applicable)
  • I added unit tests to ensure my change works (when change in Java or on front-end code)
  • I added UI tests to ensure my UI changes work (when change in the overall UI, not needed if just adding a challenge)
  • The PR passes pre-commit hooks and automated tests

@Shubham-Patel07
Copy link
Contributor Author

Hi @commjoen sir,
Is there anything else expected here in this pull request?

@commjoen
Copy link
Collaborator

No sir, we might need to relocate the example files, but otherwise we are good ;-)

@Shubham-Patel07
Copy link
Contributor Author

Done !!

Copy link
Collaborator

@commjoen commjoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the challenge! I did some small fixes and textual changes, and now it looks awesome! @bendehaan what is your take on it?

Note: we only need to update the docker-compose reference in the text after merge to master ;-)

@commjoen commjoen merged commit ca2cbab into OWASP:master Oct 31, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add misconfiguration of docker secret in code (See for docker compose: https://docs.docker.com/engine/swarm/secrets/)

2 participants