Fix for #278 missing html escaping for dot #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was possible to inject html markup in the label of a dot node. This lead to the error observed in OWASP#278. This fix is currently only for the label attribute. Other attribute might be affected as well.
|
I thought injecting HTML in the labels was a feature, not a bug, to give people more latitude in formatting their diagrams. Am I wrong? |
|
If it is a feature it needs to be documented. Since this was news to me. The html in dot is just a reduced set of html and so has no security implications. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was possible to inject html markup in the label of a dot node. This lead to the error observed in #278.
This fix is currently only for the label attribute. Other attribute might be affected as well.