Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for the Russian Translation #620

Merged
merged 6 commits into from
Jan 26, 2022
Merged

Conversation

CthUlhUzzz
Copy link
Contributor

@CthUlhUzzz CthUlhUzzz commented Jan 24, 2022

Corrected typos in the Russian translation. Translated the latest changelog update.

Closes #567

@cpholguera
Copy link
Collaborator

Hi @CthUlhUzzz, thanks a lot for your PR addressing that issue. We'll try to review it as soon as possible.

@julepka if you have some time could you please take a look? Thanks a lot in advance ☺️

Copy link
Collaborator

@julepka julepka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CthUlhUzzz good job!
I've added a couple of suggestions. Please, review.

Document-ru/CHANGELOG.md Outdated Show resolved Hide resolved
Document-ru/CHANGELOG.md Outdated Show resolved Hide resolved
Document-ru/CHANGELOG.md Outdated Show resolved Hide resolved
@CthUlhUzzz
Copy link
Contributor Author

@julepka, Done 👍

@cpholguera cpholguera changed the title Russian fixes Fixes for the Russian Translation Jan 25, 2022
@cpholguera
Copy link
Collaborator

Thanks a lot @CthUlhUzzz and @julepka for the corrections, this is very helpful!

@cpholguera
Copy link
Collaborator

Hi @CthUlhUzzz, we need one last thing before merging. Could you please pull the latest changes from master? Thanks!

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@CthUlhUzzz
Copy link
Contributor Author

@cpholguera, I'm ready 😎

Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @CthUlhUzzz we're ready to go! and btw. since this is your first contribution I officially welcome you to the team. You'll appear as a new contributor on our next MASVS release!

We'll be happy to have more contributions from you, please take a look at the MSTG open Issues and Discussions or ask us directly and we can gladly guide you.

Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @CthUlhUzzz we're ready to go! and btw. since this is your first contribution I officially welcome you to the team. You'll appear as a new contributor on our next MASVS release!

We'll be happy to have more contributions from you, please take a look at the MSTG open Issues and Discussions or ask us directly and we can gladly guide you.

@cpholguera cpholguera merged commit 152519e into OWASP:master Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Russian Translation
3 participants