Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSTG-PLATFORM-10 Add WebViews Cleanup #1984

Merged
merged 14 commits into from
Jul 8, 2022
Merged

Conversation

cpholguera
Copy link
Collaborator

@cpholguera cpholguera commented Nov 20, 2021

This PR addresses the Android part of #1487.

Document/0x05h-Testing-Platform-Interaction.md Outdated Show resolved Hide resolved
Document/0x05h-Testing-Platform-Interaction.md Outdated Show resolved Hide resolved
Document/0x05h-Testing-Platform-Interaction.md Outdated Show resolved Hide resolved
Document/0x05h-Testing-Platform-Interaction.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@TheDauntless TheDauntless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍺

@cpholguera cpholguera marked this pull request as ready for review January 23, 2022 15:48
@cpholguera cpholguera marked this pull request as draft January 23, 2022 19:30
@cpholguera
Copy link
Collaborator Author

Turning into draft again. I noticed that the links were now outdated and I was searching for newer examples. I will also add the iOS counterpart.

@cpholguera cpholguera marked this pull request as ready for review June 30, 2022 08:08
Document/0x05h-Testing-Platform-Interaction.md Outdated Show resolved Hide resolved
Document/0x05h-Testing-Platform-Interaction.md Outdated Show resolved Hide resolved
Document/0x05h-Testing-Platform-Interaction.md Outdated Show resolved Hide resolved
Document/0x05h-Testing-Platform-Interaction.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@TheDauntless TheDauntless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tiny things to maybe merge and then it's good to go :)

Document/0x05h-Testing-Platform-Interaction.md Outdated Show resolved Hide resolved
Document/0x05h-Testing-Platform-Interaction.md Outdated Show resolved Hide resolved
Document/0x05h-Testing-Platform-Interaction.md Outdated Show resolved Hide resolved
@cpholguera cpholguera merged commit 231bccb into master Jul 8, 2022
@cpholguera cpholguera deleted the add-webviews-cleanup branch July 8, 2022 07:43
@cpholguera cpholguera changed the title Testing MSTG-PLATFORM-10 (WebViews cleanup) MSTG-PLATFORM-10 Add WebViews Cleanup Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants