Add GitHub actions for testing #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csware
force-pushed
the
github-actions
branch
3 times, most recently
from
50172c6 to
416ad80
Compare
Signed-off-by: Sven Strickroth <[email protected]>
Signed-off-by: Sven Strickroth <[email protected]>
Signed-off-by: Sven Strickroth <[email protected]>
mikesamuel
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use GitHub actions for testing
Currently it will fail because of issue #301 (cf. https://github.com/csware/java-html-sanitizer/actions/runs/7623931014) and commit 91c5fdc.
See that it works in principle: https://github.com/csware/java-html-sanitizer/actions/runs/7623897965 which is based on commit 8277dbc and passes the tests
It would also be nice if workflows could be allowed by default (as no GitHub secrets are used)
Btw. I noticed that Travis was used, however, it does not work any more. Should the references (e.g., in README.md) be removed? Also, the coverage report seems to be way outdated.