Fixes open port print in port_scan module. #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanaydin
force-pushed
the
fix-for-port-number-in-port-scanner-output
branch
2 times, most recently
from
a3e2328 to
7cd7526
Compare
The issue caused the program to erroneously run a regex pattern on HTML content instead of the request data. This was because the port number wasn't displayed in the HTML's body content. The commit rectifies this problem, ensuring that regex operates on the correct data.
tanaydin
force-pushed
the
fix-for-port-number-in-port-scanner-output
branch
from
e86c431 to
2da26e6
Compare
securestep9
approved these changes
Dec 22, 2024
|
thank you for your contribution @tanaydin |
tanaydin
commented
Feb 8, 2025
| @@ -1028,7 +1028,7 @@ payloads: | |||
| condition_type: or | |||
| conditions: | |||
| open_port: | |||
| regex: "" | |||
| regex: \d{{1,5}} | |||
There was a problem hiding this comment.
this is wrong, it must be like
[0-9]{{1,5}}
\d accepts other alphabets digits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes found open port printing problem in port_scan module output.
it is printing like this
conditions: open_port: - ''
after that fix, it is
conditions: open_port: - '443'
Checklist
make pre-commit, it didn't generate any changesmake test, all tests passed locally