Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove numpy dependency #947

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Remove numpy dependency #947

merged 4 commits into from
Nov 5, 2024

Conversation

arkid15r
Copy link
Collaborator

Stacked on #946

Remove numpy dependency.

@arkid15r arkid15r requested a review from securestep9 as a code owner October 21, 2024 22:14
@securestep9
Copy link
Collaborator

Will try to test this on a large number of targets

Base automatically changed from numpy-related-updates to master October 27, 2024 16:50
@securestep9
Copy link
Collaborator

@arkid15r There is a conflict to be resolved in nettacker/core/utils/common.py

arkid15r
arkid15r commented Oct 30, 2024
View reviewed changes
Copy link
Collaborator Author

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

@arkid15r arkid15r enabled auto-merge October 30, 2024 01:08
@arkid15r arkid15r added this pull request to the merge queue Nov 5, 2024
@securestep9 securestep9 self-assigned this Nov 5, 2024
Merged via the queue into master with commit 5f6bc8e Nov 5, 2024
17 checks passed
@arkid15r arkid15r deleted the remove-numpy-dependency branch November 5, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@securestep9 securestep9 securestep9 approved these changes

Assignees

@securestep9 securestep9

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arkid15r @securestep9