updated regex for SSH scanning to include more matches #1012
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
The current regex for SSH port matching is correct for matching banners from Ubuntu, Debian, FreeBSD SSH banners, however a lot of services have SSH banners that are like this
SSH-2.0-ad34f3baf
For example, running the following reveals the same for github.com,
nc -v github.com 22
Thus, to match these as well, I have updated the regex.
Type of change
Checklist
make pre-commit
, it didn't generate any changesmake test
, all tests passed locallyAdditional info
Future work includes creating NULL probes to capture banners of services that reveal it without any explicit probing (like SSH, FTP) along with the arbitrary probe that is currently defined.