Skip to content

fix: consistent focus outlines for header and footer #3950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kasya merged 5 commits into from
Feb 20, 2026
Merged

fix: consistent focus outlines for header and footer #3950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9b5de37
fix: improve focus outlines
cnaples79 Feb 14, 2026
d1299e0
a11y: improve focus indicator consistency
cnaples79 Feb 14, 2026
e32688a
Update code
arkid15r Feb 15, 2026
61eb340
Merge branch 'main' into fix/a11y-focus-outline
arkid15r Feb 15, 2026
15b7412
Merge branch 'main' into fix/a11y-focus-outline
kasya Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions frontend/src/components/Footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export default function Footer() {
<Button
disableAnimation
onPress={() => toggleSection(section.title)}
className="flex w-full items-center justify-between bg-transparent pl-0 text-left text-lg font-semibold focus:ring-slate-400 focus:outline-hidden lg:cursor-default"
className="flex w-full items-center justify-between rounded-md bg-transparent pl-0 text-left text-lg font-semibold focus-visible:outline focus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-blue-500 lg:cursor-default"
aria-expanded={openSection === section.title}
aria-controls={`footer-section-${section.title}`}
>
Expand All @@ -42,8 +42,10 @@ export default function Footer() {
</Button>
<div
id={`footer-section-${section.title}`}
className={`flex flex-col gap-2 overflow-hidden text-sm transition-all duration-300 ease-in-out lg:max-h-full ${
openSection === section.title ? 'max-h-96' : 'max-h-0 lg:max-h-full'
className={`flex flex-col gap-2 text-sm transition-all duration-300 ease-in-out ${
openSection === section.title
? 'max-h-96'
: 'max-h-0 overflow-hidden lg:max-h-full lg:overflow-visible'
}`}
>
{section.links.map((link) => (
Expand All @@ -52,7 +54,7 @@ export default function Footer() {
<span className="text-slate-600 dark:text-slate-400">{link.text}</span>
) : (
<Link
className="text-slate-600 hover:text-slate-900 dark:text-slate-400 dark:hover:text-slate-100"
className="rounded-md text-slate-600 hover:text-slate-900 focus-visible:outline focus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-blue-500 dark:text-slate-400 dark:hover:text-slate-100"
href={link.href || '/'}
rel="noopener noreferrer"
target="_blank"
Expand All @@ -78,7 +80,7 @@ export default function Footer() {
target="_blank"
rel="noopener noreferrer"
aria-label={`OWASP Nest ${social.label}`}
className="text-slate-600 transition-colors duration-200 hover:text-slate-900 dark:text-slate-400 dark:hover:text-slate-100"
className="rounded-full p-2 text-slate-600 transition-colors duration-200 hover:text-slate-900 focus-visible:outline focus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-blue-500 dark:text-slate-400 dark:hover:text-slate-100"
>
<SocialIcon className="h-4 w-4" />
</Link>
Expand All @@ -94,7 +96,7 @@ export default function Footer() {
{RELEASE_VERSION && (
<p className="text-sm text-slate-600 dark:text-slate-400">
<Link
className="text-slate-600 hover:text-slate-900 dark:text-slate-400 dark:hover:text-slate-100"
className="rounded-md text-slate-600 hover:text-slate-900 focus-visible:outline focus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-blue-500 dark:text-slate-400 dark:hover:text-slate-100"
href={
ENVIRONMENT === 'production'
? `https://github.com/OWASP/Nest/releases/tag/${RELEASE_VERSION}`
Expand Down
14 changes: 11 additions & 3 deletions frontend/src/components/Header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,11 @@ export default function Header({ isGitHubAuthEnabled }: { readonly isGitHubAuthE
<header className="bg-owasp-blue fixed inset-x-0 top-0 z-50 w-full shadow-md dark:bg-slate-800">
<div className="flex h-16 w-full items-center px-4 max-lg:justify-between" id="navbar-sticky">
{/* Logo */}
<Link href="/" onClick={() => setMobileMenuOpen(false)}>
<Link
href="/"
onClick={() => setMobileMenuOpen(false)}
className="rounded-lg focus-visible:outline focus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-white"
>
<div className="flex h-full items-center">
<div className="flex h-16 w-16 items-center justify-center py-2">
<Image
Expand Down Expand Up @@ -133,7 +137,7 @@ export default function Header({ isGitHubAuthEnabled }: { readonly isGitHubAuthE
<div className="lg:hidden">
<Button
onPress={toggleMobileMenu}
className="flex h-11 w-11 items-center justify-center bg-transparent text-slate-300 hover:bg-transparent hover:text-slate-100 focus:outline-hidden"
className="flex h-11 w-11 items-center justify-center rounded-lg bg-transparent text-slate-300 hover:bg-transparent hover:text-slate-100 focus-visible:outline focus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-white"
>
<span className="sr-only">Open main menu</span>
{mobileMenuOpen ? <FaTimes className="h-6 w-6" /> : <FaBars className="h-6 w-6" />}
Expand All @@ -150,7 +154,11 @@ export default function Header({ isGitHubAuthEnabled }: { readonly isGitHubAuthE
<div className="flex h-full flex-col justify-between gap-1 px-2 pt-2 pb-3">
{/* Logo */}
<div className="flex flex-col justify-center gap-5">
<Link href="/" onClick={() => setMobileMenuOpen(false)}>
<Link
href="/"
onClick={() => setMobileMenuOpen(false)}
className="rounded-lg focus-visible:outline focus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-white"
>
<div className="flex h-full items-center">
<div className="flex h-16 w-16 items-center justify-center py-2">
<Image
Expand Down