Sync feature/nest-zappa-migration with main#3933
Conversation
Bumps certbot/certbot from v5.3.0 to v5.3.1. --- updated-dependencies: - dependency-name: certbot/certbot dependency-version: v5.3.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* added community endpoint to HIDDEN_SEGMENT * Update code * add tests for breadcrumbs --------- Co-authored-by: Arkadii Yakovets <arkadii.yakovets@owasp.org> Co-authored-by: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com>
OWASP#3855) (OWASP#3894) Apply pessimistic locking in update_program, update_program_status, and update_module per maintainer feedback (select_for_update least intrusive). Co-authored-by: Cursor <cursoragent@cursor.com>
* Fix PLC0415 violations * Update code * Update code --------- Co-authored-by: Arkadii Yakovets <arkadii.yakovets@owasp.org> Co-authored-by: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com>
* fix(models): check for None instead of falsy in geo-location * fix(models): check for None instead of falsy in geo-location * fix(models): correct comment formatting * fixed comments in tests/models * fixed comments * fixed tests * Update code --------- Co-authored-by: Arkadii Yakovets <arkadii.yakovets@owasp.org> Co-authored-by: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com>
* fix(frontend): make dev footer version link to commit (fixes OWASP#3892) - Footer version is now always a clickable link - Production: links to release tag (unchanged) - Non-production with dash in RELEASE_VERSION: links to commit - Non-production without dash: falls back to release tag URL - Added unit tests for Version Link Behavior * Update code * Update code --------- Co-authored-by: Arkadii Yakovets <arkadii.yakovets@owasp.org>
* Add SBOM generation for docker image * Enable continue-on-error for SBOM generation Added continue-on-error flag to SBOM generation steps. * ci: run Trivy SBOM generation via Docker container * ci: run Trivy SBOM generation via Makefile * add local image build guard to sbom-frontend-image Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com> * add local image build guard to sbom-backend-image Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com> * Attach SBOMS to Github Release * Update code --------- Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com> Co-authored-by: Arkadii Yakovets <arkadii.yakovets@owasp.org> Co-authored-by: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com>
…ers (fixes OWASP#3783) (OWASP#3799) * Refactor Dockerfile to improve caching and security * Update base.py * Update graphql.py * Update production.py * Apply suggestion from @cubic-dev-ai[bot] Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com> * Update Dockerfile * Update Dockerfile * Add security settings for HSTS and SSL Added security settings for HSTS and SSL redirection. * Simplify GraphQL schema extensions setup Refactor GraphQL schema extensions and configuration. * Update staging.py * Update staging.py * Update code * Update code --------- Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com> Co-authored-by: Arkadii Yakovets <arkadii.yakovets@owasp.org> Co-authored-by: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com>
…SP#3920) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6.18.0 to 6.19.1. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@2634353...601a80b) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-version: 6.19.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* update:model,management * update:model * update:cleaned * update:cleaned * initial test added needed corrections * some more test * test added : * code rabbit * code rabbit * correction * code-rabbit * code-rabbit * code-rabbit * code-rabbit * sonar-issue * cspell_check * lint/format * lint/format * lint/format * lint/format * lint/format * lint/format * final lint/format * cleaned code * lint/format code-rabbit * lint/format code-rabbit * lint/format code-rabbit * lint/format * lint/format * lint/format * code-rabbit * code-rabbit * lint/format * lint/format * resolved conflicts * ' lint/format * lint/format * Update code * Update code * Fix tests --------- Co-authored-by: Arkadii Yakovets <arkadii.yakovets@owasp.org>
|
Important Review skippedToo many files! This PR contains 168 files, which is 18 over the limit of 150. You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
PR validation failed: No linked issue and no valid closing issue reference in PR description |
|
There was a problem hiding this comment.
1 issue found across 172 files
Confidence score: 4/5
- Single medium-severity CI configuration concern; overall risk appears low and safe to merge with a small permissions cleanup.
scan-staging-imagesin.github/workflows/run-ci-cd.yamlrequestscontents: writeeven thoughactions/upload-artifactdoesn’t need it, which could be over-privileged compared to the production scan job.- Pay close attention to
.github/workflows/run-ci-cd.yaml- remove unnecessarycontents: writepermissions in the staging scan job.
Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed.
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name=".github/workflows/run-ci-cd.yaml">
<violation number="1" location=".github/workflows/run-ci-cd.yaml:586">
P2: Unnecessary permission escalation: `scan-staging-images` uses `actions/upload-artifact` which doesn't require `contents: write`. Unlike the production scan job (which uses `gh release upload`), this job should keep `contents: read` to follow the principle of least privilege.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| RELEASE_VERSION: ${{ needs.set-release-version.outputs.release_version }} | ||
| permissions: | ||
| contents: read | ||
| contents: write |
There was a problem hiding this comment.
P2: Unnecessary permission escalation: scan-staging-images uses actions/upload-artifact which doesn't require contents: write. Unlike the production scan job (which uses gh release upload), this job should keep contents: read to follow the principle of least privilege.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/run-ci-cd.yaml, line 586:
<comment>Unnecessary permission escalation: `scan-staging-images` uses `actions/upload-artifact` which doesn't require `contents: write`. Unlike the production scan job (which uses `gh release upload`), this job should keep `contents: read` to follow the principle of least privilege.</comment>
<file context>
@@ -579,8 +579,11 @@ jobs:
+ RELEASE_VERSION: ${{ needs.set-release-version.outputs.release_version }}
permissions:
- contents: read
+ contents: write
runs-on: ubuntu-latest
steps:
</file context>
| contents: write | |
| contents: read |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature/nest-zappa-migration #3933 +/- ##
================================================================
- Coverage 95.38% 93.32% -2.07%
================================================================
Files 464 513 +49
Lines 14554 15827 +1273
Branches 2017 2134 +117
================================================================
+ Hits 13883 14770 +887
- Misses 328 695 +367
- Partials 343 362 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 32 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
fc6363b
into
OWASP:feature/nest-zappa-migration



Sync feature/nest-zappa-migration
Proposed change
Resolves #(put the issue number here)
Add the PR description here.
Checklist
make check-testlocally: all warnings addressed, tests passed