Skip to content

fix: Prevent lost updates in concurrent Program/Module edits using select_for_update() #3894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arkid15r merged 2 commits into from
Feb 11, 2026
Merged

fix: Prevent lost updates in concurrent Program/Module edits using select_for_update() #3894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbe4c47
fix(mentorship): use select_for_update() to prevent lost updates (fix…
preeeetham Feb 10, 2026
77f4acd
Merge branch 'main' into fix/3855-select-for-update
preeeetham Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions backend/apps/mentorship/api/internal/mutations/module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,8 +330,10 @@ def update_module(self, info: strawberry.Info, input_data: UpdateModuleInput) ->
user = info.context.request.user

try:
module = Module.objects.select_related("program").get(
key=input_data.key, program__key=input_data.program_key
module = (
Module.objects.select_related("program")
.select_for_update()
.get(key=input_data.key, program__key=input_data.program_key)
)
except Module.DoesNotExist as e:
raise ObjectDoesNotExist(MODULE_NOT_FOUND_MSG) from e
Expand Down
4 changes: 2 additions & 2 deletions backend/apps/mentorship/api/internal/mutations/program.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def update_program(self, info: strawberry.Info, input_data: UpdateProgramInput)
user = info.context.request.user

try:
program = Program.objects.get(key=input_data.key)
program = Program.objects.select_for_update().get(key=input_data.key)
except Program.DoesNotExist as err:
msg = f"Program with key '{input_data.key}' not found."
logger.warning(msg, exc_info=True)
Expand Down Expand Up @@ -144,7 +144,7 @@ def update_program_status(
user = info.context.request.user

try:
program = Program.objects.get(key=input_data.key)
program = Program.objects.select_for_update().get(key=input_data.key)
except Program.DoesNotExist as e:
msg = f"Program with key '{input_data.key}' not found."
raise ObjectDoesNotExist(msg) from e
Expand Down
Loading