-
-
Notifications
You must be signed in to change notification settings - Fork 521
Refactor dateFormatter to strictly accept numeric Unix timestamps #3857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Mr-Rahul-Paul
wants to merge
20
commits into
OWASP:main
Choose a base branch
from
Mr-Rahul-Paul:fix#3371
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
242498d
take only number as date input (for unix timestamp)
Mr-Rahul-Paul 44523e5
fixed date format in tsx files
Mr-Rahul-Paul 3f10348
fixed test file
Mr-Rahul-Paul 4cc4569
changed tests
Mr-Rahul-Paul 373278f
start and end dates take number only now
Mr-Rahul-Paul 80261a2
date formatter fucntions take numbers as input now
Mr-Rahul-Paul f439242
fixed components - take format dates as numbers and compoenet schema …
Mr-Rahul-Paul 6376a9b
fix format dates
Mr-Rahul-Paul 9d80b79
fixed mock data
Mr-Rahul-Paul 43e9420
tests and mock data have unix timestamps , not strings
Mr-Rahul-Paul 699de52
add specific test date
Mr-Rahul-Paul 78c6ea4
added unix timestamps instead of helper fn
Mr-Rahul-Paul fb768d7
address issues presented by bots
Mr-Rahul-Paul fa0c4aa
formatdate method handle strings recieved from backend
Mr-Rahul-Paul 0c8e9eb
cleaned dateformatter.ts
Mr-Rahul-Paul 4882665
addressed bot issue
Mr-Rahul-Paul 8fec84e
fix formatDateForInput method and add tests
Mr-Rahul-Paul 0a81843
address redundant check + add test
Mr-Rahul-Paul 911ae4c
fixed if condition
Mr-Rahul-Paul bb81fcf
Merge branch 'main' into fix#3371
Mr-Rahul-Paul File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.