Skip to content

Update issues table to use LabelLists instead of custom labels#3816

Merged
arkid15r merged 4 commits intomainfrom
update-issues-labels
Feb 7, 2026
Merged

Update issues table to use LabelLists instead of custom labels#3816
arkid15r merged 4 commits intomainfrom
update-issues-labels

Conversation

@kasya
Copy link
Collaborator

@kasya kasya commented Feb 7, 2026

Updated Mentorship portal Issues table to use existing LabelList component instead of generic labels

Checklist

  • Required: I followed the contributing workflow
  • Required: I verified that my code works as intended and resolves the issue as described
  • Required: I ran make check-test locally: all warnings addressed, tests passed
  • I used AI for code, documentation, tests, or communication related to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 7, 2026

Summary by CodeRabbit

  • Refactor

    • Enhanced code organization for label display in the issues table, improving maintainability.
  • Tests

    • Expanded test coverage with comprehensive verification of label rendering across multiple scenarios and configurations.

Walkthrough

Replaces inline per-label rendering in IssuesTable with a LabelList component and updates unit tests to mock and assert LabelList props (entityKey, labels, maxVisible), ensuring previous maxVisibleLabels behavior is preserved.

Changes

Cohort / File(s) Summary
Label rendering refactor
frontend/src/components/IssuesTable.tsx
Replaces manual per-label span rendering and "+ N more" logic with a LabelList component usage; passes entityKey, labels (default []), maxVisible, and className.
Tests: LabelList integration
frontend/__tests__/unit/components/IssuesTable.test.tsx
Adds a mocked LabelList component and new assertions verifying entityKey derivation, labels normalization (empty -> []), maxVisible sourcing (default or prop), and call counts/per-issue behavior.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • arkid15r
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: replacing custom label rendering with the LabelList component in the issues table.
Description check ✅ Passed The description clearly explains the change and includes a completed checklist confirming the code works and tests pass.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch update-issues-labels

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

cubic-dev-ai[bot]
cubic-dev-ai bot previously approved these changes Feb 7, 2026
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

coderabbitai[bot]
coderabbitai bot previously approved these changes Feb 7, 2026
@codecov
Copy link

codecov bot commented Feb 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.23%. Comparing base (0976876) to head (b8a9584).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3816      +/-   ##
==========================================
- Coverage   90.24%   90.23%   -0.02%     
==========================================
  Files         463      463              
  Lines       14410    14411       +1     
  Branches     1936     1936              
==========================================
- Hits        13005    13004       -1     
- Misses        987      988       +1     
- Partials      418      419       +1     
Flag Coverage Δ
backend 90.97% <ø> (ø)
frontend 88.17% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
frontend/src/components/IssuesTable.tsx 91.66% <100.00%> (-0.44%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0976876...b8a9584. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2026

@kasya kasya marked this pull request as ready for review February 7, 2026 03:33
@kasya kasya requested a review from arkid15r as a code owner February 7, 2026 03:33
@arkid15r arkid15r added this pull request to the merge queue Feb 7, 2026
Merged via the queue into main with commit 3d62fb2 Feb 7, 2026
38 checks passed
@arkid15r arkid15r deleted the update-issues-labels branch February 7, 2026 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants