Skip to content

fix: remove redundant type assertion in EditProgramPage #3653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Adarshkumar0509 wants to merge 3 commits into from
Closed

fix: remove redundant type assertion in EditProgramPage #3653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32ac7ac
fix: remove redundant type assertion in EditProgramPage
Adarshkumar0509 Jan 29, 2026
487db89
chore: restore ExtendedSession cast for admin check
Adarshkumar0509 Jan 29, 2026
1850a17
chore: use optional chaining in organizations list
Adarshkumar0509 Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions frontend/src/app/my/mentorship/programs/[programKey]/edit/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
'use client'

import type { ExtendedSession } from 'types/auth'
import { useMutation, useQuery } from '@apollo/client/react'
import { addToast } from '@heroui/toast'
import { useRouter, useParams } from 'next/navigation'
Expand All @@ -13,7 +13,6 @@ import {
GetMyProgramsDocument,
GetProgramDetailsDocument,
} from 'types/__generated__/programsQueries.generated'
import type { ExtendedSession } from 'types/auth'
import { formatDateForInput } from 'utils/dateFormatter'
import { parseCommaSeparated } from 'utils/parser'
import LoadingSpinner from 'components/LoadingSpinner'
Expand Down Expand Up @@ -54,10 +53,9 @@ const EditProgramPage = () => {
return
}

const isAdmin = data.getProgram.admins?.some(
(admin: { login: string }) => admin.login === (session as ExtendedSession)?.user?.login
)

const isAdmin = data.getProgram.admins?.some(
(admin: { login: string }) => admin.login === (session as ExtendedSession)?.user?.login
)
Comment on lines +56 to +58
Copy link
Collaborator

@kasya kasya Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change indentation here? And I believe the assertion (the issue you needed to fix) is still there 👀

if (isAdmin) {
setAccessStatus('allowed')
} else {
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/app/organizations/page.tsx
View file
Open in desktop
Copy link
Collaborator

@kasya kasya Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is from a different PR

Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ const OrganizationPage = () => {
totalPages={totalPages}
>
<div className="grid grid-cols-1 gap-6 sm:grid-cols-2 lg:grid-cols-3 xl:grid-cols-4">
{organizations && organizations.map(renderOrganizationCard)}
{organizations?.map(renderOrganizationCard)}
</div>
</SearchPageLayout>
)
Expand Down