fix: remove redundant type assertion (S4325)

[anukalp2804]

Proposed change

Resolves #3554

This PR fixes a Sonar-reported code smell (typescript:S4325).

The type assertion (session as ExtendedSession) was redundant and did not change the effective type of the expression when optional chaining was already used. The assertion has been removed to improve readability and align with TypeScript and Sonar best practices.

No functional changes.

Checklist

• Required: I followed the contributing workflow
• Required: I verified that my code works as intended and resolves the issue as described
• Required: I ran make check-test locally
• I used AI for code, documentation, tests, or communication related to this PR

[coderabbitai]

Summary by CodeRabbit

• Refactor
  • Centralized retrieval of the signed-in user and simplified admin verification logic, removing an internal type dependency and improving code clarity and maintainability; no user-facing changes.

Walkthrough

Replaced runtime type assertion of session with direct optional-chained access session?.user?.login in the mentorship program edit page; removed dependency on ExtendedSession. No other logic or control-flow changes.

Changes

Cohort / File(s)	Summary
Type assertion removal frontend/src/app/my/mentorship/programs/[programKey]/edit/page.tsx	Replaced (session as ExtendedSession)?.user?.login with session?.user?.login in admin comparisons; removed ExtendedSession dependency/import.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• refactor: remove redundant type assertions in frontend #3258: Similar removal of ExtendedSession casts and replacement with optional-chained session?.user?.login.
• refactor: simplify session casting and improve type safety in MyMento… #3505: Same refactor pattern replacing session casts with local optional-chained login extraction.

Suggested reviewers

• arkid15r

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'fix: remove redundant type assertion (S4325)' is specific and clearly related to the main change: removing a redundant type assertion to fix a Sonar code smell.
Description check	✅ Passed	The description is fully related to the changeset, detailing the removal of the redundant type assertion and its motivation, linking to issue #3554.
Linked Issues check	✅ Passed	The PR directly addresses issue #3554 by removing the redundant type assertion (session as ExtendedSession) from the comparison, exactly as required.
Out of Scope Changes check	✅ Passed	All changes are scoped to fixing the Sonar issue S4325; the refactoring only affects the admin login comparison logic without introducing unrelated modifications.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[anukalp2804]

Hi @arkid15r @kasya , this PR addresses the assigned Sonar issue (typescript:S4325).
Please let me know if any changes are needed. Thanks!

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@frontend/src/app/my/mentorship/programs/`[programKey]/edit/page.tsx:
- Around line 56-59: The access to session?.user?.login in the isAdmin check is
unsafe because the base next-auth Session type doesn't include login; either
reintroduce the cast (session as ExtendedSession)?.user?.login in the isAdmin
expression or add a module augmentation to extend next-auth's Session type to
include user.login so TypeScript recognizes it; update the isAdmin line
(referencing isAdmin, session, ExtendedSession, and data.getProgram.admins)
accordingly to restore type safety.

[anukalp2804]

Thanks for the review! I’ve updated the code to safely narrow the session.user type before accessing login.
Please let me know if anything else needs adjustment.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[cubic-dev-ai]

No issues found across 1 file

[kasya]

@anukalp2804 thanks for working on this!
I updated your PR - you did not run make check-test locally and it is required. Please make sure to run it next time.

[codecov]

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 87.67%. Comparing base (71f63bc) to head (64e8977).
⚠️ Report is 36 commits behind head on main.

Files with missing lines	Patch %	Lines
.../my/mentorship/programs/[programKey]/edit/page.tsx	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3628      +/-   ##
==========================================
+ Coverage   85.55%   87.67%   +2.12%     
==========================================
  Files         463      462       -1     
  Lines       14303    14324      +21     
  Branches     1904     1915      +11     
==========================================
+ Hits        12237    12559     +322     
+ Misses       1687     1346     -341     
- Partials      379      419      +40     

Flag	Coverage Δ
backend	87.45% <ø> (+2.91%)	⬆️
frontend	88.29% <50.00%> (-0.10%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
.../my/mentorship/programs/[programKey]/edit/page.tsx	66.66% <50.00%> (-1.08%)	⬇️

... and 23 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71f63bc...64e8977. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.