Fix negative indexing in recentProjects and recentMilestones

backend/apps/github/api/internal/nodes/repository.py

@@ -15,6 +15,7 @@
 if TYPE_CHECKING:
     from apps.owasp.api.internal.nodes.project import ProjectNode
 
+MAX_LIMIT = 1000
 RECENT_ISSUES_LIMIT = 5
 RECENT_RELEASES_LIMIT = 5
 
@@ -69,6 +70,16 @@ def project(
     @strawberry_django.field(prefetch_related=["milestones"])
     def recent_milestones(self, root: Repository, limit: int = 5) -> list[MilestoneNode]:
         """Resolve recent milestones."""
+        try:
+            limit = int(limit)
+        except (TypeError, ValueError):
+            return []
+
+        if limit <= 0:
+            return []
+
+        limit = min(limit, MAX_LIMIT)
+
         return root.recent_milestones.order_by("-created_at")[:limit]
 
     @strawberry_django.field(prefetch_related=["releases"])

backend/apps/github/api/internal/queries/milestone.py

@@ -76,8 +76,14 @@ def recent_milestones(
                 id__in=Subquery(latest_milestone_per_author),
             )
 
-        return (
-            milestones.order_by("-created_at")[:limit]
-            if (limit := min(limit, MAX_LIMIT)) > 0
-            else []
-        )
+        try:
+            limit = int(limit)
+        except (TypeError, ValueError):
+            return []
+
+        if limit <= 0:
+            return []
+
+        limit = min(limit, MAX_LIMIT)
+
+        return milestones.order_by("-created_at")[:limit]

backend/apps/owasp/api/internal/nodes/project.py

@@ -53,11 +53,17 @@ def health_metrics_list(
         self, root: Project, limit: int = 30
     ) -> list[ProjectHealthMetricsNode]:
         """Resolve project health metrics."""
-        return (
-            root.health_metrics.order_by("nest_created_at")[:limit]
-            if (limit := min(limit, MAX_LIMIT)) > 0
-            else []
-        )
+        try:
+            limit = int(limit)
+        except (TypeError, ValueError):
+            return []
+
+        if limit <= 0:
+            return []
+
+        limit = min(limit, MAX_LIMIT)
+
+        return root.health_metrics.order_by("nest_created_at")[:limit]
 
     @strawberry_django.field(prefetch_related=["health_metrics"])
     def health_metrics_latest(self, root: Project) -> ProjectHealthMetricsNode | None:
@@ -87,6 +93,16 @@ def recent_issues(self, root: Project) -> list[IssueNode]:
     @strawberry_django.field
     def recent_milestones(self, root: Project, limit: int = 5) -> list[MilestoneNode]:
         """Resolve recent milestones."""
+        try:
+            limit = int(limit)
+        except (TypeError, ValueError):
+            return []
+
+        if limit <= 0:
+            return []
+
+        limit = min(limit, MAX_LIMIT)
+
         return (
             Milestone.objects.filter(
                 repository__in=root.repositories.all(),
@@ -95,12 +111,8 @@ def recent_milestones(self, root: Project, limit: int = 5) -> list[MilestoneNode
                 "repository__organization",
                 "author__owasp_profile",
             )
-            .prefetch_related(
-                "labels",
-            )
+            .prefetch_related("labels")
             .order_by("-created_at")[:limit]
-            if (limit := min(limit, MAX_LIMIT)) > 0
-            else []
         )
 
     @strawberry_django.field

backend/apps/owasp/api/internal/queries/project.py

@@ -45,11 +45,17 @@ def recent_projects(self, limit: int = 8) -> list[ProjectNode]:
             list[ProjectNode]: A list of recent active projects.
 
         """
-        return (
-            Project.objects.filter(is_active=True).order_by("-created_at")[:limit]
-            if (limit := min(limit, MAX_RECENT_PROJECTS_LIMIT)) > 0
-            else []
-        )
+        try:
+            limit = int(limit)
+        except (TypeError, ValueError):
+            return []
+
+        if limit <= 0:
+            return []
+
+        limit = min(limit, MAX_RECENT_PROJECTS_LIMIT)
+
+        return Project.objects.filter(is_active=True).order_by("-created_at")[:limit]
 
     @strawberry_django.field
     def search_projects(self, query: str) -> list[ProjectNode]: