Skip to content

fix issue#3477

Merged
arkid15r merged 2 commits intoOWASP:mainfrom
mrkeshav-05:fix/issue-3475
Jan 22, 2026
Merged

fix issue#3477
arkid15r merged 2 commits intoOWASP:mainfrom
mrkeshav-05:fix/issue-3475

Conversation

@mrkeshav-05
Copy link
Contributor

Proposed change

This PR resolves the backend issue of getting error while updating the program status.
Resolves #3475

Checklist

  • Required: I followed the contributing workflow
  • Required: I verified that my code works as intended and resolves the issue as described
  • Required: I ran make check-test locally: all warnings addressed, tests passed
  • I used AI for code, documentation, tests, or communication related to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 22, 2026

Summary by CodeRabbit

  • Refactor
    • Updated signal handler parameter naming to align with Django conventions for improved code consistency.

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

The signal handler in the mentorship program module has its method signature updated to use conventional Django signal parameters (sender, kwargs) instead of underscore-prefixed variants (_sender, _kwargs), with a linting directive added.

Changes

Cohort / File(s) Summary
Signal handler parameter convention update
backend/apps/mentorship/signals/program.py
Updated program_post_save_clear_algolia_cache function signature from _sender, instance, **_kwargs to sender, instance, **kwargs with # noqa: ARG001 directive; no behavior changes

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

backend

Suggested reviewers

  • arkid15r
  • kasya
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'fix issue' is vague and does not clearly describe the specific change being made. Use a more specific title that describes the actual fix, such as 'Fix Django signal handler parameter naming in program post-save signal' or 'Update program post-save signal handler to use standard Django parameter names'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description is related to the changeset and clearly references the linked issue #3475 about backend errors during program status updates.
Linked Issues check ✅ Passed The PR updates signal handler parameter names from non-standard to conventional Django naming, which addresses the backend error in program status updates referenced in issue #3475.
Out of Scope Changes check ✅ Passed The change to the signal handler parameter names is directly related to fixing the backend error in issue #3475, with no apparent out-of-scope modifications.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

@arkid15r arkid15r enabled auto-merge January 22, 2026 20:32
@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.60%. Comparing base (01fa577) to head (2286c9d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3477   +/-   ##
=======================================
  Coverage   85.60%   85.60%           
=======================================
  Files         461      461           
  Lines       14222    14222           
  Branches     1894     1894           
=======================================
  Hits        12175    12175           
  Misses       1678     1678           
  Partials      369      369           
Flag Coverage Δ
backend 84.47% <ø> (ø)
frontend 88.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01fa577...2286c9d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arkid15r arkid15r disabled auto-merge January 22, 2026 20:58
@arkid15r arkid15r enabled auto-merge January 22, 2026 20:58
@arkid15r arkid15r disabled auto-merge January 22, 2026 20:59
@arkid15r arkid15r merged commit 6838e55 into OWASP:main Jan 22, 2026
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Backend error occurs when updating program status

2 participants

Comments