Skip to content

Fix/remove redundant non null assertions #3306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anukalp2804 wants to merge 14 commits into from
Closed

Fix/remove redundant non null assertions #3306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
d537a58
fix: remove redundant non-null assertions
anukalp2804 Jan 6, 2026
107460b
fix: remove remaining redundant non-null assertions
anukalp2804 Jan 6, 2026
497a985
chore: replace 1.0 with 1 to satisfy sonar rule
anukalp2804 Jan 6, 2026
b138be6
chore: remove unintended package-lock.json from PR
anukalp2804 Jan 7, 2026
ec72199
Fix zap scan (#3198)
kart-u Jan 6, 2026
c22fbe8
Define explicit top-level permissions for GitHub Actions workflows (#…
SuyashJain17 Jan 6, 2026
f21cfe6
Update .zapconfig
arkid15r Jan 6, 2026
cc3a470
Run make update
arkid15r Jan 6, 2026
47613b5
Update .zapconfig
arkid15r Jan 6, 2026
40be57e
Fix/remove zero fractions (#3224)
hussainjamal760 Jan 6, 2026
e02cac6
Update .zapconfig
arkid15r Jan 7, 2026
1e98bf6
fix: remove unused closeDelay prop from MockTooltipProps
anukalp2804 Jan 12, 2026
1554891
fix: remove redundant non-null assertions in ChapterMap keyboard tests
anukalp2804 Jan 12, 2026
0125683
fix: remove redundant return statement
anukalp2804 Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/check-pr-issue.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ on:
types:
- opened

permissions: {}

jobs:
check-pr-issue:
permissions:
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/label-issues.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ on:
- edited
- opened

permissions: {}

jobs:
label:
permissions:
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/label-pull-requests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ name: Label Pull Requests
on:
- pull_request_target

permissions: {}

jobs:
labeler:
permissions:
Expand Down
28 changes: 18 additions & 10 deletions .github/workflows/run-ci-cd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ on:
- published
workflow_dispatch:

permissions: {}

env:
FORCE_COLOR: 1

Expand Down Expand Up @@ -602,28 +604,31 @@ jobs:
working-directory: frontend

run-staging-zap-baseline-scan:
name: Run ZAP Baseline Scan
name: Run staging ZAP baseline scan
needs:
- deploy-staging-nest-proxy
permissions:
contents: read
runs-on: ubuntu-latest
steps:
- name: Run ZAP Baseline Scan
- name: Check out repository
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8

- name: Run baseline scan
uses: zaproxy/action-baseline@de8ad967d3548d44ef623df22cf95c3b0baf8b25
with:
token: ${{ secrets.GITHUB_TOKEN }}
target: 'https://nest.owasp.dev'
allow_issue_writing: false
fail_action: false
cmd_options: '-a -r zap-report.html'
cmd_options: '-a -c .zapconfig -r report.html '

- name: Upload ZAP report
- name: Upload report
if: always()
uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f
with:
name: zap-baseline-scan-report-${{ github.run_id }}
path: zap-report.html
path: report.html


build-production-images:
Expand Down Expand Up @@ -943,25 +948,28 @@ jobs:
run: ansible-playbook -i inventory.yaml production/proxy.yaml -e "github_workspace=$GITHUB_WORKSPACE"

run-production-zap-baseline-scan:
name: Run ZAP Baseline Scan
name: Run production ZAP baseline scan
needs:
- deploy-production-nest-proxy
permissions:
contents: read
runs-on: ubuntu-latest
steps:
- name: Run ZAP Baseline Scan
- name: Check out repository
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8

- name: Run baseline scan
uses: zaproxy/action-baseline@de8ad967d3548d44ef623df22cf95c3b0baf8b25
with:
token: ${{ secrets.GITHUB_TOKEN }}
target: 'https://nest.owasp.org'
allow_issue_writing: false
fail_action: false
cmd_options: '-a -r zap-report.html'
cmd_options: '-a -c .zapconfig -r report.html '

- name: Upload ZAP report
- name: Upload report
if: always()
uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f
with:
name: zap-baseline-scan-report-${{ github.run_id }}
path: zap-report.html
path: report.html
2 changes: 2 additions & 0 deletions .github/workflows/run-code-ql.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ on:
- main
workflow_dispatch:

permissions: {}

jobs:
code-ql:
name: CodeQL
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/update-nest-test-images.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ on:
- cron: 30 0 * * *
workflow_dispatch:

permissions: {}

env:
FORCE_COLOR: 1

Expand All @@ -13,6 +15,7 @@ jobs:
name: Update Nest test images
if: ${{ github.repository == 'OWASP/Nest' }}
permissions:
actions: write
contents: read
runs-on: ubuntu-latest
steps:
Expand Down
8 changes: 8 additions & 0 deletions .zapconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# Rule description: comment.
# rule_id<TAB>ACTION<TAB>(URL regex pattern)

# Information Disclosure - Suspicious Comments: source map and debug ID comments.
10027 IGNORE https://nest.owasp.(dev|org)/_next/static/chunks/[a-f0-9]{16}.js

# PII disclosure: false positive credicard number.
10062 IGNORE https://nest.owasp.(dev|org)/sitemap.xml
Comment on lines +7 to +8
Copy link
Contributor

@coderabbitai coderabbitai bot Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Minor typo: "credicard" → "creditcard".

Proposed fix 
-# PII disclosure: false positive credicard number.
+# PII disclosure: false positive credit card number.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# PII disclosure: false positive credicard number.
10062 IGNORE https://nest.owasp.(dev|org)/sitemap.xml
# PII disclosure: false positive credit card number.
10062 IGNORE https://nest.owasp.(dev|org)/sitemap.xml
🤖 Prompt for AI Agents 
In @.zapconfig around lines 7 - 8, Fix the typo in the .zapconfig comment:
change "credicard" to "creditcard" in the PII disclosure comment so the line
reads "PII disclosure: false positive creditcard number." and keep the rest of
the IGNORE entry (10062 IGNORE https://nest.owasp.(dev|org)/sitemap.xml)
unchanged.

26 changes: 16 additions & 10 deletions backend/poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions cspell/custom-dict.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ xdg
xdist
xoxb
xsser
zapconfig
zaproxy
zsc
éàëîôû
14 changes: 10 additions & 4 deletions docs/poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion frontend/__tests__/unit/components/Card.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ interface MockTooltipProps {
children: ReactNode
content: string
id?: string
closeDelay?: number
delay?: number
showArrow?: boolean
}
Expand Down
10 changes: 5 additions & 5 deletions frontend/__tests__/unit/components/ChapterMap.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ describe('ChapterMap', () => {
[-90, -180],
[90, 180],
],
maxBoundsViscosity: 1.0,
maxBoundsViscosity: 1,
scrollWheelZoom: false,
zoomControl: false,
})
Expand Down Expand Up @@ -287,7 +287,7 @@ describe('ChapterMap', () => {
const { getByText, queryByText } = render(<ChapterMap {...defaultProps} />)

const overlay = getByText('Unlock map').closest('button')
fireEvent.click(overlay!)
fireEvent.click(overlay)

expect(queryByText('Unlock map')).not.toBeInTheDocument()
})
Expand All @@ -296,7 +296,7 @@ describe('ChapterMap', () => {
const { getByText } = render(<ChapterMap {...defaultProps} />)

const overlay = getByText('Unlock map').closest('button')
fireEvent.click(overlay!)
fireEvent.click(overlay)

expect(mockMap.scrollWheelZoom.enable).toHaveBeenCalled()
})
Expand All @@ -305,7 +305,7 @@ describe('ChapterMap', () => {
const { getByText } = render(<ChapterMap {...defaultProps} />)

const overlay = getByText('Unlock map').closest('button')
fireEvent.keyDown(overlay!, { key: 'Enter' })
fireEvent.keyDown(overlay, { key: 'Enter' })

expect(mockMap.scrollWheelZoom.enable).toHaveBeenCalled()
})
Expand All @@ -314,7 +314,7 @@ describe('ChapterMap', () => {
const { getByText } = render(<ChapterMap {...defaultProps} />)

const overlay = getByText('Unlock map').closest('button')
fireEvent.keyDown(overlay!, { key: ' ' })
fireEvent.keyDown(overlay, { key: ' ' })

expect(mockMap.scrollWheelZoom.enable).toHaveBeenCalled()
})
Expand Down
2 changes: 1 addition & 1 deletion frontend/__tests__/unit/components/DonutBarChart.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ describe('DonutBarChart Component Test Suite', () => {
const chartSeries = JSON.parse(chart.dataset.series || '[]')

// Should be rounded to 1 decimal place
expect(chartSeries).toEqual([1000000.0, 1000000.0, 2000000.5])
expect(chartSeries).toEqual([1000000, 1000000, 2000000.5])
})

it('handles negative values', () => {
Expand Down
9 changes: 4 additions & 5 deletions frontend/__tests__/unit/components/ProjectsDashboardDropDown.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,6 @@ describe('ProjectsDashboardDropDown Component', () => {
) {
return
}
return
})
})

Expand Down Expand Up @@ -303,7 +302,7 @@ describe('ProjectsDashboardDropDown Component', () => {

expect(activeItem).toBeDefined()

fireEvent.click(activeItem!)
fireEvent.click(activeItem)
expect(mockOnAction).toHaveBeenCalledWith('Active')
})

Expand All @@ -317,7 +316,7 @@ describe('ProjectsDashboardDropDown Component', () => {

expect(activeItem).toBeDefined()

fireEvent.keyDown(activeItem!, { key: 'Enter' })
fireEvent.keyDown(activeItem, { key: 'Enter' })
expect(mockOnAction).toHaveBeenCalledWith('Active')
})

Expand All @@ -333,8 +332,8 @@ describe('ProjectsDashboardDropDown Component', () => {
expect(activeItem).toBeDefined()
expect(inactiveItem).toBeDefined()

fireEvent.click(activeItem!)
fireEvent.click(inactiveItem!)
fireEvent.click(activeItem)
fireEvent.click(inactiveItem)

expect(mockOnAction).toHaveBeenCalledTimes(2)
expect(mockOnAction).toHaveBeenCalledWith('Active')
Expand Down
2 changes: 1 addition & 1 deletion frontend/__tests__/unit/data/mockCommitteeDetailsData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
export const mockCommitteeDetailsData = {
committee: {
name: 'Test Committee',
updatedAt: 1734103212.0,
updatedAt: 1734103212,
leaders: ['Leader 1', 'Leader 2'],
url: 'https://owasp.org/test-committee',
summary: 'This is a test committee summary.',
Expand Down
2 changes: 1 addition & 1 deletion frontend/__tests__/unit/data/mockSnapshotData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export const mockSnapshotDetailsData = {
name: '',
},
],
updatedAt: 1727353371.0,
updatedAt: 1727353371,
url: 'https://owasp.org/www-chapter-sivagangai',
relatedUrls: [],
geoLocation: {
Expand Down
2 changes: 1 addition & 1 deletion frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"dayjs": "^1.11.19",
"dompurify": "^3.3.1",
"eslint-plugin-import": "^2.32.0",
"framer-motion": "^12.24.0",
"framer-motion": "^12.24.7",
"graphql": "^16.12.0",
"ics": "^3.8.1",
"leaflet": "^1.9.4",
Expand Down
Loading