Skip to content

Refactor: Replace negated conditions with positive checks #3274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arkid15r merged 4 commits into from
Jan 10, 2026
Merged

Refactor: Replace negated conditions with positive checks #3274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4c9f77e
Refactor: Replace negated conditions with positive checks
saniyafatima07 Jan 10, 2026
926e8ee
Merge branch 'main' into san
saniyafatima07 Jan 10, 2026
1420143
Update code
arkid15r Jan 10, 2026
96048e4
Merge branch 'main' into san
arkid15r Jan 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/src/app/board/[year]/candidates/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,13 +477,13 @@ const BoardCandidatesPage = () => {
(
{ledChapters.length > 0 && (
<>
{ledChapters.length} chapter{ledChapters.length !== 1 ? 's' : ''}
{ledChapters.length} chapter{ledChapters.length === 1 ? '' : 's'}
</>
)}
{ledChapters.length > 0 && ledProjects.length > 0 && ', '}
{ledProjects.length > 0 && (
<>
{ledProjects.length} project{ledProjects.length !== 1 ? 's' : ''}
{ledProjects.length} project{ledProjects.length === 1 ? '' : 's'}
</>
)}
)
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/CardDetailsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ const DetailsCard = ({
detail?.label === 'Leaders' ? (
<div key={detail.label} className="flex flex-row gap-1 pb-1">
<strong>{detail.label}:</strong>{' '}
<LeadersList leaders={detail?.value != null ? String(detail.value) : 'Unknown'} />
<LeadersList leaders={detail?.value == null ? 'Unknown' : String(detail.value)} />
</div>
) : (
<div key={detail.label} className="pb-1">
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/components/ModuleCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ export const getSimpleDuration = (start: string | number, end: string | number):

const ms = endDate.getTime() - startDate.getTime()
const days = Math.floor(ms / (1000 * 60 * 60 * 24))

const weeks = Math.ceil(days / 7)
return `${weeks} week${weeks !== 1 ? 's' : ''}`

return `${weeks} week${weeks === 1 ? '' : 's'}`
}
6 changes: 3 additions & 3 deletions frontend/src/components/SearchPageLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,7 @@ const SearchPageLayout = ({
initialValue={searchQuery}
/>
</div>
{!isLoaded ? (
<SkeletonBase indexName={indexName} loadingImageUrl={loadingImageUrl} />
) : (
{isLoaded ? (
<>
<div>
{totalPages !== 0 && <div className="flex justify-end">{sortChildren}</div>}
Expand All @@ -67,6 +65,8 @@ const SearchPageLayout = ({
/>
)}
</>
) : (
<SkeletonBase indexName={indexName} loadingImageUrl={loadingImageUrl} />
)}
</div>
)
Expand Down